Skip to content

chore(refactor): simplify auto-sync and alreadyAttemptedSync#23628

Merged
crenshaw-dev merged 11 commits intoargoproj:masterfrom
agaudreault:refactor-alreadyAttemptedSync
Jul 14, 2025
Merged

chore(refactor): simplify auto-sync and alreadyAttemptedSync#23628
crenshaw-dev merged 11 commits intoargoproj:masterfrom
agaudreault:refactor-alreadyAttemptedSync

Conversation

@agaudreault
Copy link
Copy Markdown
Member

Part of #23356

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@agaudreault agaudreault requested a review from a team as a code owner July 1, 2025 21:09
@bunnyshell
Copy link
Copy Markdown

bunnyshell bot commented Jul 1, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@agaudreault agaudreault enabled auto-merge (squash) July 1, 2025 22:03
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 1, 2025

Codecov Report

❌ Patch coverage is 92.06349% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.08%. Comparing base (56f8797) to head (c624b58).
⚠️ Report is 812 commits behind head on master.

Files with missing lines Patch % Lines
controller/appcontroller.go 91.30% 3 Missing and 1 partial ⚠️
controller/state.go 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #23628      +/-   ##
==========================================
- Coverage   60.21%   60.08%   -0.14%     
==========================================
  Files         346      346              
  Lines       59230    59295      +65     
==========================================
- Hits        35667    35628      -39     
- Misses      20709    20795      +86     
- Partials     2854     2872      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@crenshaw-dev
Copy link
Copy Markdown
Member

crenshaw-dev commented Jul 3, 2025

@agaudreault if it's a functional change, we should label it as a fix and add a test for #23615

@agaudreault
Copy link
Copy Markdown
Member Author

Moved to #23655

@agaudreault agaudreault disabled auto-merge July 3, 2025 21:06
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
…ttemptedSync

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@agaudreault agaudreault requested review from a team and crenshaw-dev July 10, 2025 16:09
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) July 14, 2025 14:00
@crenshaw-dev crenshaw-dev merged commit 2c4dd51 into argoproj:master Jul 14, 2025
27 checks passed
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
…j#23628)

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: enneitex <etienne.divet@gmail.com>
Mangaal pushed a commit to Mangaal/argo-cd that referenced this pull request Sep 10, 2025
…j#23628)

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
sivasath16 pushed a commit to sivasath16/argo-cd that referenced this pull request Sep 17, 2025
…j#23628)

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
sivasath16 pushed a commit to sivasath16/argo-cd that referenced this pull request Sep 17, 2025
…j#23628)

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants