chore: replace heptio-images with argocd-e2e-container (#23040)

[nitishfy]

Cherry-pick #23040

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[nitishfy]

Tried setting up the e2e tests locally via make start-e2e, but i got the following error:

Done in 147.92s.
find /go/src/github.com/argoproj/argo-cd -name debug.test -exec rm -f {} +
CGO_ENABLED=0 GODEBUG="tarinsecurepath=0,zipinsecurepath=0" go build -gcflags="all=-N -l"  -v -ldflags '-X github.com/argoproj/argo-cd/v2/common.version=2.14.11 -X github.com/argoproj/argo-cd/v2/common.buildDate=2025-05-28T09:27:32Z -X github.com/argoproj/argo-cd/v2/common.gitCommit=1e8b35588cf1db42929ed034b68b3578eb970376 -X github.com/argoproj/argo-cd/v2/common.gitTreeState=dirty -X github.com/argoproj/argo-cd/v2/common.kubectlVersion=v0.31.0 -X "github.com/argoproj/argo-cd/v2/common.extraBuildInfo=" -extldflags "-static"' -o /go/src/github.com/argoproj/argo-cd/dist/argocd ./cmd
github.com/argoproj/argo-cd/v2/cmd
kubectl create ns argocd-e2e || true
The connection to the server 127.0.0.1:50176 was refused - did you specify the right host or port?
kubectl create ns argocd-e2e-external || true
The connection to the server 127.0.0.1:50176 was refused - did you specify the right host or port?
kubectl create ns argocd-e2e-external-2 || true
The connection to the server 127.0.0.1:50176 was refused - did you specify the right host or port?
kubectl config set-context --current --namespace=argocd-e2e
Context "kind-kind" modified.
kustomize build test/manifests/base | kubectl apply -f -
error: error validating "STDIN": error validating data: failed to download openapi: Get "https://127.0.0.1:50176/openapi/v2?timeout=32s": dial tcp 127.0.0.1:50176: connect: connection refused; if you choose to ignore these errors, turn validation off with --validate=false
make: *** [Makefile:462: start-e2e-local] Error 1
make: *** [start-e2e] Error 2

Any suggestions how to fix this? cc @rumstead

[codecov]

Codecov Report

❌ Patch coverage is 64.28571% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.40%. Comparing base (ddb6073) to head (a0909fc).
⚠️ Report is 24 commits behind head on release-2.14.

Files with missing lines	Patch %	Lines
cmd/argocd/commands/app.go	40.00%	6 Missing ⚠️
server/server.go	50.00%	3 Missing and 3 partials ⚠️
util/argo/audit_logger.go	73.68%	5 Missing ⚠️
cmd/argocd/commands/applicationset.go	0.00%	3 Missing ⚠️
cmd/argocd/commands/cert.go	0.00%	3 Missing ⚠️
cmd/argocd/commands/cluster.go	0.00%	3 Missing ⚠️
util/notification/settings/legacy.go	25.00%	3 Missing ⚠️
cmd/argocd/commands/app_resources.go	50.00%	2 Missing ⚠️
cmd/util/cluster.go	81.81%	1 Missing and 1 partial ⚠️
controller/appcontroller.go	71.42%	0 Missing and 2 partials ⚠️
... and 12 more

Additional details and impacted files

@@               Coverage Diff                @@
##           release-2.14   #23060      +/-   ##
================================================
+ Coverage         52.93%   55.40%   +2.47%     
================================================
  Files               339      339              
  Lines             57431    57433       +2     
================================================
+ Hits              30399    31821    +1422     
+ Misses            24367    22921    -1446     
- Partials           2665     2691      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ppapapetrou76]

Out of curiosity why did we remove these linters in the first place?
I'm pretty sure there was a discussion but I'm new here so I can't find it

[nitishfy]

That's lint which did that. I'm working on fixing it.

[crenshaw-dev]

Let's not cherry-pick this. There are a lot of changes, and they're not necessary to make e2e tests pass on the release-2.14 branch. Plus 2.14 will go EOL soon anyway.