Skip to content

fix: remove default spec.preserveUnknownFields ignoreDifference for CRD #22948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reggie-k merged 5 commits into from
May 18, 2025
Merged

fix: remove default spec.preserveUnknownFields ignoreDifference for CRD #22948

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e76285b
docs: impact of changing compareoptions default
mikutas May 13, 2025
7080fb2
docs: add explanation
mikutas May 14, 2025
1285936
remove preserve unknown fields and update docs
agaudreault May 14, 2025
6562f3a
Merge branch 'master' into docs-impact-of-changing-default
agaudreault May 14, 2025
8929f52
Update docs/operator-manual/upgrading/2.14-3.0.md
agaudreault May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/operator-manual/upgrading/2.14-3.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,8 @@ By default, the compare options to ignore the status field has been changed from

This means that differences won't be detected anymore for fields that are part of the status.

On the other hand, CRD's `spec.preserveUnknownFields` will become detected by default. The field is ignored implicitly when compare option is `crd` but when `all` it's not ignored.

Comment thread
agaudreault marked this conversation as resolved.
Outdated
If you rely on the status field being part of your desired state, the `ignoreResourceStatusField` setting can be used to preserve the v2 default.

```yaml
Expand Down