fix: Race condition in nativeGitClient.LsFiles (issue #21754)

[magat]

Changing the current working directory is not safe for concurrent use. To avoid this, I am adding the repository root as a prefix to the pattern.

To make sure the results are relevant I also needed to evaluate symlinks in the repository root path, in case part of it is a symlink (which is the case in for temporary directories on Mac OS).

Fixes #21754. Thanks to @crenshaw-dev for providing a unit test for the race condition.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[codecov]

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.84%. Comparing base (0dfdb0a) to head (f6e5028).
⚠️ Report is 493 commits behind head on master.

Files with missing lines	Patch %	Lines
util/git/client.go	75.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #22878      +/-   ##
==========================================
- Coverage   59.93%   59.84%   -0.09%     
==========================================
  Files         344      344              
  Lines       57715    57722       +7     
==========================================
- Hits        34590    34546      -44     
- Misses      20369    20404      +35     
- Partials     2756     2772      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rumstead]

Overall, the code LGTM.

I didn't do any due diligence when I suggested to prepend the git root, I think there shouldn't be any adverse side effects.

[nitishfy]

Suggested change

	func (m *nativeGitClient) LsFiles(path string, enableNewGitFileGlobbing bool) ([]string, error) {
	func (m *nativeGitClient) LsFiles(pattern string, enableNewGitFileGlobbing bool) ([]string, error) {

Shouldn't this be pattern instead?

[rumstead]

it can be either. it depends on what is put inside the applicationset, but the globs are still representing a path.

[magat]

Both names are fine by me. I can change it to pattern if you think it's better, lmk

[nitishfy]

If you look at the applicationset code, especially this, it is a little confusing whether it's pattern or path.

[rumstead]

it's based on what the user provides in their applicationset, it can be either a path or a path glob. we use the term path in the git generator. i would suggest it stays the same.

[nitishfy]

Left a minor comment, PTAL.

[blakepettersson]

LGTM

[rumstead]

/cherry-pick release-3.0

[nitishfy]

/cherry-pick release-2.14

[gcp-cherry-pick-bot]

Cherry-pick failed with Merge error 992ee25bd359f058f7b280649d84235513f442ad into temp-cherry-pick-4154fe-release-2.14