Skip to content

feat!: update compareoptions default values #22230

Merged
agaudreault merged 7 commits intoargoproj:masterfrom
agaudreault:default-v3-compare-opts
Mar 11, 2025
Merged

feat!: update compareoptions default values #22230
agaudreault merged 7 commits intoargoproj:masterfrom
agaudreault:default-v3-compare-opts

Conversation

@agaudreault
Copy link
Copy Markdown
Member

@agaudreault agaudreault commented Mar 6, 2025

Description

  • Ignore all resource status from diff instead of just CRD
  • Automatically add the user defined differences to ignored resource updates

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@agaudreault agaudreault requested review from a team as code owners March 6, 2025 16:37
@bunnyshell
Copy link
Copy Markdown

bunnyshell bot commented Mar 6, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@agaudreault agaudreault enabled auto-merge (squash) March 7, 2025 20:04
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.84%. Comparing base (14a09be) to head (5326341).
Report is 432 commits behind head on master.

Files with missing lines Patch % Lines
util/settings/settings.go 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22230      +/-   ##
==========================================
+ Coverage   55.82%   55.84%   +0.01%     
==========================================
  Files         342      342              
  Lines       57213    57215       +2     
==========================================
+ Hits        31940    31951      +11     
+ Misses      22639    22628      -11     
- Partials     2634     2636       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

data:
resource.customizations.ignoreResourceUpdates.external-secrets.io_ExternalSecret: |
resource.customizations.ignoreResourceUpdates.external-secrets.io_ExternalSecret:
|
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intended?

@andrii-korotkov-verkada andrii-korotkov-verkada added the ready-for-review An approver should give a final review and merge the PR label Mar 9, 2025
@github-project-automation github-project-automation bot moved this to Ready for final review in Argo CD Review Mar 9, 2025
Copy link
Copy Markdown
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@agaudreault agaudreault merged commit cca7485 into argoproj:master Mar 11, 2025
32 checks passed
PaulSonOfLars pushed a commit to PaulSonOfLars/argo-cd that referenced this pull request Mar 22, 2025
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Hapshanko pushed a commit to Hapshanko/argo-cd that referenced this pull request Apr 29, 2025
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Hapshanko <adamgaming391100@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review An approver should give a final review and merge the PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants