Skip to content

feat(appcontroller): Using impersonation when an application is deleted#21800

Draft
anandf wants to merge 1 commit intoargoproj:masterfrom
anandf:app_delete_with_impersonation
Draft

feat(appcontroller): Using impersonation when an application is deleted#21800
anandf wants to merge 1 commit intoargoproj:masterfrom
anandf:app_delete_with_impersonation

Conversation

@anandf
Copy link
Copy Markdown
Member

@anandf anandf commented Feb 6, 2025

When implementing the app sync with impersonation feature, application controller impersonates only for a sync operation. This PR is enhancing that feature for the application deletion as well. When admin users want to avoid accidental deletion of resources, they can control it by removing the delete access to the impersonated service account.

Related PR: #17403
Feature proposal for impersonation: #14255

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@anandf anandf requested a review from a team as a code owner February 6, 2025 04:31
@bunnyshell
Copy link
Copy Markdown

bunnyshell bot commented Feb 6, 2025

❗ Preview Environment undeploy from Bunnyshell failed

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to try again to remove the environment

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 55.63%. Comparing base (6daaac5) to head (82058d5).

Files with missing lines Patch % Lines
controller/appcontroller.go 75.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21800      +/-   ##
==========================================
- Coverage   55.64%   55.63%   -0.02%     
==========================================
  Files         339      339              
  Lines       56876    56892      +16     
==========================================
+ Hits        31651    31653       +2     
- Misses      22583    22593      +10     
- Partials     2642     2646       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anandf anandf force-pushed the app_delete_with_impersonation branch from 52a1014 to 8afa66e Compare February 7, 2025 01:01
@anandf anandf marked this pull request as draft February 7, 2025 01:02
@anandf anandf force-pushed the app_delete_with_impersonation branch from 8afa66e to 29c98db Compare February 13, 2025 16:16
Signed-off-by: anandf <anjoseph@redhat.com>
@anandf anandf force-pushed the app_delete_with_impersonation branch from 29c98db to 82058d5 Compare February 14, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant