feat(appcontroller): Using impersonation when an application is deleted#21800
Draft
anandf wants to merge 1 commit intoargoproj:masterfrom
Draft
feat(appcontroller): Using impersonation when an application is deleted#21800anandf wants to merge 1 commit intoargoproj:masterfrom
anandf wants to merge 1 commit intoargoproj:masterfrom
Conversation
❗ Preview Environment undeploy from Bunnyshell failedSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21800 +/- ##
==========================================
- Coverage 55.64% 55.63% -0.02%
==========================================
Files 339 339
Lines 56876 56892 +16
==========================================
+ Hits 31651 31653 +2
- Misses 22583 22593 +10
- Partials 2642 2646 +4 ☔ View full report in Codecov by Sentry. |
52a1014 to
8afa66e
Compare
8afa66e to
29c98db
Compare
Signed-off-by: anandf <anjoseph@redhat.com>
29c98db to
82058d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When implementing the app sync with impersonation feature, application controller impersonates only for a sync operation. This PR is enhancing that feature for the application deletion as well. When admin users want to avoid accidental deletion of resources, they can control it by removing the delete access to the impersonated service account.
Related PR: #17403
Feature proposal for impersonation: #14255
Checklist: