fix(cli): Fix appset generate in --core mode for cluster gen#21170
Merged
ishitasequeira merged 1 commit intoargoproj:masterfrom Dec 16, 2024
Merged
fix(cli): Fix appset generate in --core mode for cluster gen#21170ishitasequeira merged 1 commit intoargoproj:masterfrom
ishitasequeira merged 1 commit intoargoproj:masterfrom
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
OpenGuidou
force-pushed
the
appsetgen
branch
from
9a51d39 to
a17f086
Compare
OpenGuidou
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21170 +/- ##
==========================================
+ Coverage 53.79% 55.19% +1.39%
==========================================
Files 324 324
Lines 55603 55607 +4
==========================================
+ Hits 29914 30690 +776
+ Misses 23087 22289 -798
- Partials 2602 2628 +26 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@andrii-korotkov-verkada @ishitasequeira would you mind checking this one as well ? |
andrii-korotkov-verkada
approved these changes
Dec 13, 2024
andrii-korotkov-verkada
added
the
ready-for-review
Contributor
Author
|
/cherry-pick release-2.13 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
ishitasequeira
pushed a commit
that referenced
this pull request
Dec 18, 2024
…) (#21236) Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com> Co-authored-by: OpenGuidou <73480729+OpenGuidou@users.noreply.github.com>
dudo
pushed a commit
to dudo/argo-cd
that referenced
this pull request
Jan 18, 2025
…proj#21170) Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com> Signed-off-by: Brett C. Dudo <brett@dudo.io>
revitalbarletz
pushed a commit
to revitalbarletz/argo-cd
that referenced
this pull request
Jan 20, 2025
…proj#21170) Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
vasilegroza
pushed a commit
to vasilegroza/argo-cd
that referenced
this pull request
Feb 27, 2025
…proj#21170) Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complement of #20717 for the use case with cluster generators, producing the error:
error getting cluster secrets: no kind is registered for the type v1.SecretList in schemeChecklist: