fix: oras-go client should fallback to docker config if no credentials specified (cherry-pick 2.13 #18133)#20872
Conversation
…s specified (argoproj#18133) * oras-go client should fallback to docker config if no credentials specified Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io> * Fix tests Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io> * Fix lint Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io> * gofumpt Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io> * Validate auth header Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io> --------- Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>
|
This is a manual cherry-pick because (This is my first time filing a PR against Argo CD; please let me know if I need to adjust anything. If and when it's approved, I'll create the equivalent PRs for 2.11 and 2.12.) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-2.13 #20872 +/- ##
================================================
+ Coverage 55.01% 55.04% +0.03%
================================================
Files 320 320
Lines 54735 54743 +8
================================================
+ Hits 30111 30136 +25
+ Misses 22045 22035 -10
+ Partials 2579 2572 -7 ☔ View full report in Codecov by Sentry. |
|
codegen is expected to fail, only other thing to knock out is DCO. Can you fix that check? |
|
I'm not sure what to do about this DCO check failure -- it looks like the original author's Github email address has changed, and no longer matches the signoff on the original commit:
Should I add my own sign-off to the end of the commit message? |
fix: oras-go client should fallback to docker config if no credentials specified (cherry-pick 2.13 #18133)