Skip to content

fix: oras-go client should fallback to docker config if no credentials specified (cherry-pick 2.13 #18133)#20872

Merged
crenshaw-dev merged 1 commit intoargoproj:release-2.13from
eestolano:oras-fix-2.13
Jan 22, 2025
Merged

fix: oras-go client should fallback to docker config if no credentials specified (cherry-pick 2.13 #18133)#20872
crenshaw-dev merged 1 commit intoargoproj:release-2.13from
eestolano:oras-fix-2.13

Conversation

@eestolano
Copy link
Copy Markdown

fix: oras-go client should fallback to docker config if no credentials specified (cherry-pick 2.13 #18133)

…s specified (argoproj#18133)

* oras-go client should fallback to docker config if no credentials specified

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

* Fix tests

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

* Fix lint

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

* gofumpt

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

* Validate auth header

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

---------

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>
@eestolano eestolano requested a review from a team as a code owner November 20, 2024 20:16
@eestolano
Copy link
Copy Markdown
Author

This is a manual cherry-pick because gcp-cherry-pick-bot didn't pick up the /cherry-pick release-2.11, /cherry-pick release-2.12, and /cherry-pick release-2.13 comments in #18133.

(This is my first time filing a PR against Argo CD; please let me know if I need to adjust anything. If and when it's approved, I'll create the equivalent PRs for 2.11 and 2.12.)

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.04%. Comparing base (af54ef8) to head (fcc6d87).
Report is 46 commits behind head on release-2.13.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-2.13   #20872      +/-   ##
================================================
+ Coverage         55.01%   55.04%   +0.03%     
================================================
  Files               320      320              
  Lines             54735    54743       +8     
================================================
+ Hits              30111    30136      +25     
+ Misses            22045    22035      -10     
+ Partials           2579     2572       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev
Copy link
Copy Markdown
Member

codegen is expected to fail, only other thing to knock out is DCO. Can you fix that check?

@eestolano
Copy link
Copy Markdown
Author

I'm not sure what to do about this DCO check failure -- it looks like the original author's Github email address has changed, and no longer matches the signoff on the original commit:

Commit sha: fcc6d87, Author: Tony Au-Yeung, Committer: Esteban Molina-Estolano; Can not find "Tony Au-Yeung tonyay163@gmail.com", in ["Tony Au-Yeung tony@elevenlabs.io", "Tony Au-Yeung tony@elevenlabs.io", "Tony Au-Yeung tony@elevenlabs.io", "Tony Au-Yeung tony@elevenlabs.io", "Tony Au-Yeung tony@elevenlabs.io", "Tony Au-Yeung tony@elevenlabs.io"].

Should I add my own sign-off to the end of the commit message?

@crenshaw-dev crenshaw-dev merged commit 53dc116 into argoproj:release-2.13 Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants