-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: only check for source position when --show-params is set #20682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
christianh814
approved these changes
Nov 6, 2024
wanghong230
approved these changes
Nov 6, 2024
jessesuen
approved these changes
Nov 6, 2024
ishitasequeira
approved these changes
Nov 6, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20682 +/- ##
==========================================
- Coverage 55.20% 55.18% -0.02%
==========================================
Files 324 324
Lines 55256 55257 +1
==========================================
- Hits 30505 30496 -9
+ Misses 22143 22140 -3
- Partials 2608 2621 +13 ☔ View full report in Codecov by Sentry. |
/cherry-pick release-2.13 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
gdsoumya
added a commit
that referenced
this pull request
Nov 7, 2024
…0689) Signed-off-by: Soumya Ghosh Dastidar <[email protected]> Co-authored-by: Soumya Ghosh Dastidar <[email protected]>
adriananeci
pushed a commit
to adriananeci/argo-cd
that referenced
this pull request
Dec 4, 2024
) Signed-off-by: Soumya Ghosh Dastidar <[email protected]> Signed-off-by: Adrian Aneci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20670
This PR ensures that
app get
works for multi source apps even when--source-position
isn't provided.Source position check is only necessary if the user also sets
--show-params
Checklist: