fix: the unmatching template issue introduced from #20237#20410
Merged
ishitasequeira merged 3 commits intoargoproj:masterfrom Oct 17, 2024
Merged
fix: the unmatching template issue introduced from #20237#20410ishitasequeira merged 3 commits intoargoproj:masterfrom
ishitasequeira merged 3 commits intoargoproj:masterfrom
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
christianh814
approved these changes
Oct 16, 2024
6cf0c80 to
4cdf072
Compare
The error in the notification controller shows unmatching "{{end}}"
```
error in 'app-health-degraded' teams.potentialAction: template:
app-health-degraded:14: unexpected {{end}}"
```
Signed-off-by: Pan Luo <pan.luo@ubc.ca>
4cdf072 to
3102f0e
Compare
Signed-off-by: Pan Luo <pan.luo@ubc.ca>
d6c5964 to
23e2360
Compare
Signed-off-by: Pan Luo <pan.luo@ubc.ca>
206797f to
a25bdb4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20410 +/- ##
==========================================
+ Coverage 56.02% 56.05% +0.02%
==========================================
Files 322 322
Lines 44802 44802
==========================================
+ Hits 25099 25112 +13
+ Misses 17104 17086 -18
- Partials 2599 2604 +5 ☔ View full report in Codecov by Sentry. |
4ch3los
pushed a commit
to 4ch3los/argo-cd
that referenced
this pull request
Oct 17, 2024
…goproj#20410) * Fix the unmatching template error The error in the notification controller shows unmatching "{{end}}" ``` error in 'app-health-degraded' teams.potentialAction: template: app-health-degraded:14: unexpected {{end}}" ``` Signed-off-by: Pan Luo <pan.luo@ubc.ca> * update templates to match the install.yaml Signed-off-by: Pan Luo <pan.luo@ubc.ca> * fix inconsistent yaml block style formating Signed-off-by: Pan Luo <pan.luo@ubc.ca> --------- Signed-off-by: Pan Luo <pan.luo@ubc.ca>
adriananeci
pushed a commit
to adriananeci/argo-cd
that referenced
this pull request
Dec 4, 2024
…goproj#20410) * Fix the unmatching template error The error in the notification controller shows unmatching "{{end}}" ``` error in 'app-health-degraded' teams.potentialAction: template: app-health-degraded:14: unexpected {{end}}" ``` Signed-off-by: Pan Luo <pan.luo@ubc.ca> * update templates to match the install.yaml Signed-off-by: Pan Luo <pan.luo@ubc.ca> * fix inconsistent yaml block style formating Signed-off-by: Pan Luo <pan.luo@ubc.ca> --------- Signed-off-by: Pan Luo <pan.luo@ubc.ca> Signed-off-by: Adrian Aneci <aneci@adobe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error in the notification controller shows unmatching "{{end}}"
This PR is to correct the above issue and make the notification controller happy again!
Since #20237 has not been included in any release yet. No cherry-pick is needed.
Checklist: