fix: Rework git tag semver resolution (#20083) (cherry-pick #20096)#20213
Merged
ishitasequeira merged 1 commit intorelease-2.13from Oct 7, 2024
Merged
fix: Rework git tag semver resolution (#20083) (cherry-pick #20096)#20213ishitasequeira merged 1 commit intorelease-2.13from
ishitasequeira merged 1 commit intorelease-2.13from
Conversation
* Write initial tests Signed-off-by: Paul Larsen <pnvlarsen@gmail.com> * Improve git tag semver resolution Signed-off-by: Paul Larsen <pnvlarsen@gmail.com> * Add company to list of users Signed-off-by: Paul Larsen <pnvlarsen@gmail.com> * Fix broken error string check Signed-off-by: Paul Larsen <pnvlarsen@gmail.com> * Fix incorrect semver test assumption Signed-off-by: Paul Larsen <pnvlarsen@gmail.com> * switch to debug statement Signed-off-by: Paul Larsen <pnvlarsen@gmail.com> * Add more testcases for review Signed-off-by: Paul Larsen <pnvlarsen@gmail.com> * review comments Signed-off-by: Paul Larsen <pnvlarsen@gmail.com> --------- Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
blakepettersson
approved these changes
Oct 4, 2024
blakepettersson
added
the
ready-for-review
ishitasequeira
approved these changes
Oct 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-2.13 #20213 +/- ##
================================================
+ Coverage 55.78% 55.82% +0.03%
================================================
Files 320 320
Lines 44384 44388 +4
================================================
+ Hits 24759 24778 +19
+ Misses 17060 17047 -13
+ Partials 2565 2563 -2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix: Rework git tag semver resolution (#20083) (#20096)
Signed-off-by: Paul Larsen pnvlarsen@gmail.com
Signed-off-by: Paul Larsen pnvlarsen@gmail.com
Signed-off-by: Paul Larsen pnvlarsen@gmail.com
Signed-off-by: Paul Larsen pnvlarsen@gmail.com
Signed-off-by: Paul Larsen pnvlarsen@gmail.com
Signed-off-by: Paul Larsen pnvlarsen@gmail.com
Signed-off-by: Paul Larsen pnvlarsen@gmail.com
Signed-off-by: Paul Larsen pnvlarsen@gmail.com
Signed-off-by: Paul Larsen pnvlarsen@gmail.com