-
Notifications
You must be signed in to change notification settings - Fork 7k
feat: Add nodeSelector for Linux nodes #20148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
crenshaw-dev
merged 9 commits into
argoproj:master
from
leehosu:feat/fix-node-selector-linux-only
Oct 1, 2024
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e3acfb2
feat: Add nodeSelector for Linux nodes in application-controller, app…
leehosu a2f1181
refactor : Reversal the wrong part and correct it.
leehosu 6e2d261
Update argocd-application-controller-statefulset.yaml
leehosu f3f1a93
Merge branch 'argoproj:master' into feat/fix-node-selector-linux-only
leehosu 7b07096
feat: Add nodeSelector for Linux nodes in dex-server, argo-server
leehosu 541e24b
Merge branch 'master' into feat/fix-node-selector-linux-only
leehosu 4f8100e
refactor: update code to resolving for intergration test
leehosu e788ad6
refactor: update code to resolving for codegen
leehosu 878f2cd
Run make manifests-local and then commit
leehosu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -264,3 +264,5 @@ spec: | |
| items: | ||
| - key: controller.profile.enabled | ||
| path: profiler.enabled | ||
| nodeSelector: | ||
| kubernetes.io/os: linux | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -211,3 +211,5 @@ spec: | |
| path: tls.key | ||
| - key: ca.crt | ||
| path: ca.crt | ||
| nodeSelector: | ||
| kubernetes.io/os: linux | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -89,3 +89,5 @@ spec: | |
| runAsNonRoot: true | ||
| seccompProfile: | ||
| type: RuntimeDefault | ||
| nodeSelector: | ||
| kubernetes.io/os: linux | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of hard coding this for all users this it can be an optional kustomization, we can document it in the docs to let users know how/when to use the kustomization if needed instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the concern about adding this globally?
I'm not seeing a downside to applying this as it will have no effect on clusters that only have Linux nodes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit ignorant about multi-OS clusters. Do we know with reasonable certainty that
kubernetes.io/oswill be set for all nodes for all relevant versions of Kubernetes across all major vendors? Or is it just a convention that may or may not be in place?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is autopopulated by Kubernetes. See the docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In all current kubernetes clusters (version 1.14 (2019) to present (v1.31)), the
kubernetes.io/oslabel is automatically set. Previous to that, the label wasbeta.kubernetes.io/os. Versions since 1.14 seem to have both labels for reverse compatibility, but officially, beta is deprecated.