fix(appset): setApplicationSetStatusCondition updates appset in memory#19622
Closed
carlosrejano wants to merge 2 commits intoargoproj:masterfrom
Closed
fix(appset): setApplicationSetStatusCondition updates appset in memory#19622carlosrejano wants to merge 2 commits intoargoproj:masterfrom
setApplicationSetStatusCondition updates appset in memory#19622carlosrejano wants to merge 2 commits intoargoproj:masterfrom
Conversation
# Context: `setApplicationSetStatusCondition` function does not update the appset in memory after updating it in the cluster, this means that new updates using the appset object in memory may fail due to conflict. Before it was not an issue since `setApplicationSetStatusCondition` was almost always used before finishing the reconcile so no new updates were done. Now this function is also used when performing progressive syncs as introduced in this PR: argoproj#19473 So it's very likely that a new update after this function so new updates may fail due to conflict. # What does this PR? - After updating the appset object in `setApplicationSetStatusCondition` it gets the object again to reference it in the appset pointer of the reconciler. Signed-off-by: Carlos Rejano <carlos.rejano@adevinta.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Contributor
Author
|
I believe that this does not do any change, I checked and the I'm closing It in favor of #19663 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
setApplicationSetStatusConditionfunction does not update the appsetin memory after updating it in the cluster, this means that new
updates using the appset object in memory may fail due to conflict.
Before it was not an issue since
setApplicationSetStatusConditionwas almost always used before finishing the reconcile so no new
updates were done.
Now this function is also used when performing progressive syncs as
introduced in this PR: #19473
So it's very likely that a new update after this function so new
updates may fail due to conflict.
What does this PR?
setApplicationSetStatusConditionit gets the object again to reference it in the appset pointer of the reconciler.Probably fixes: #19535