fix: ArgoCD 2.11 - Loop of PATCH calls to Application objects#19569
Merged
todaywasawesome merged 1 commit intoargoproj:release-2.9from Aug 21, 2024
Merged
Conversation
jessesuen
approved these changes
Aug 16, 2024
wanghong230
approved these changes
Aug 17, 2024
Member
|
@alexmt same here, CI codegen/lint failed. |
christianh814
approved these changes
Aug 17, 2024
…oj#19340) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
force-pushed
the
patch-loop-fix-release-2.9-cherry-pick
branch
from
d457b43 to
50cc61b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-2.9 #19569 +/- ##
===============================================
- Coverage 50.14% 50.13% -0.02%
===============================================
Files 268 268
Lines 46370 46409 +39
===============================================
+ Hits 23252 23266 +14
- Misses 20864 20884 +20
- Partials 2254 2259 +5 ☔ View full report in Codecov by Sentry. |
todaywasawesome
approved these changes
Aug 21, 2024
Contributor
todaywasawesome
left a comment
todaywasawesome
left a comment
There was a problem hiding this comment.
Looks good, thanks for backporting to 2.9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR cherrypicks #19340 into release-2.9