feat(5388): Allow multiple external URLs for SSO access by ClifHouck · Pull Request #18927 · argoproj/argo-cd

ClifHouck · 2024-07-03T22:09:19Z

My organization has interest in getting this functionality merged, so I'm taking up the mantle. I've re-based the original PR on current (79b18e0) master. This currently builds, but tests do not pass. I'll be back online next week to fix tests, verify functionality of this change, and respond to any existing review comments from the original PR.

Preserving the original PR note here for reference:

With #4780, were introduced security measures to ensure the return_url is pointing to the current ArgoCD instance.

In several occasions, an ArgoCD isntance could be exposed through multiple network connections. Internal addresses and restricted public addresses.

Currently, a single base URL can be configured in the the argocd configmap, preventing from exposing ArgoCD on several access paths.

This change allows to define multiple hosts on which ArgoCD can be exposed, keeping backward compatibility by adding a field additionalUrls accepting a list of additional URLS on which argoCD can be exposed

Fixes #5388

Checklist:

bunnyshell · 2024-07-03T22:09:26Z

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

🚀 /bns:deploy to deploy the environment

bunnyshell · 2024-07-03T22:09:27Z

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

🚀 /bns:deploy to deploy the environment

agaudreault · 2024-07-04T14:25:53Z

@ClifHouck make sure to adress the review in #14208 (review). You can switch the PR to draft until the test are passing and everything is implemented. Thanks for taking up the mantle! 💪

codecov · 2024-07-08T21:56:23Z

Codecov Report

Attention: Patch coverage is 73.07692% with 14 lines in your changes missing coverage. Please review.

Project coverage is 52.78%. Comparing base (6cc898f) to head (79555cd).
Report is 506 commits behind head on master.

Files with missing lines	Patch %	Lines
util/settings/settings.go	85.18%	2 Missing and 2 partials ⚠️
server/server.go	25.00%	3 Missing ⚠️
util/oidc/oidc.go	72.72%	2 Missing and 1 partial ⚠️
server/logout/logout.go	33.33%	1 Missing and 1 partial ⚠️
util/dex/config.go	71.42%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #18927      +/-   ##
==========================================
+ Coverage   50.70%   52.78%   +2.08%     
==========================================
  Files         316      316              
  Lines       43496    43579      +83     
==========================================
+ Hits        22054    23005     +951     
+ Misses      18930    18025     -905     
- Partials     2512     2549      +37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ClifHouck

Regarding this last comment: https://github.com/argoproj/argo-cd/pull/14208/files#r1638649274 it seems like Dex is not using the new URLs setting. So I removed that addition.

ClifHouck · 2024-07-09T16:45:01Z

util/oidc/oidc.go

 }

-func (a *ClientApp) oauth2Config(scopes []string) (*oauth2.Config, error) {
+func (a *ClientApp) oauth2Config(request *http.Request, scopes []string) (*oauth2.Config, error) {


It seems like the request object is needed here. Re: https://github.com/argoproj/argo-cd/pull/14208/files#r1638640243

ClifHouck · 2024-07-09T16:45:32Z

util/settings/settings.go

 	}
+	if argoCDCM.Data[settingURLsKey] != "" {
+		if err := yaml.Unmarshal([]byte(argoCDCM.Data[settingURLsKey]), &settings.URLs); err != nil {
+			log.Warnf("Failed to decode all external URLs in configmap: %v", err)


Corrected messages here, re: https://github.com/argoproj/argo-cd/pull/14208/files#r1638642960

ClifHouck · 2024-07-09T17:18:54Z

@agaudreault I think I've addressed the comments you had on the previous PR. Except this:

I think the feature should be documented in the ArgoCD https://argo-cd.readthedocs.io/en/stable/operator-manual/user-management/ documentation.

Agreed. I can add some documentation around this feature.

Is url deprecated? are urls valid on their own or only additional urls? Is this feature supported by all identity providers, or only by OIDC?

@tjamet What do you think about the questions posed above?

ClifHouck · 2024-07-09T17:21:48Z

What do I need to about the license compliance failing? Is there a contributor agreement I need to sign?

tjamet · 2024-07-14T05:17:45Z

@agaudreault I think I've addressed the comments you had on the previous PR. Except this:

I think the feature should be documented in the ArgoCD https://argo-cd.readthedocs.io/en/stable/operator-manual/user-management/ documentation.

Agreed. I can add some documentation around this feature.

Is url deprecated? are urls valid on their own or only additional urls? Is this feature supported by all identity providers, or only by OIDC?

@tjamet What do you think about the questions posed above?

Hi!

Yes, it should be documented, happy to help doing so.

About the deprecation, this was my idea at the beginning but I faced some issues as url seemed used for more things. I will take a second look

ClifHouck · 2024-07-22T19:07:55Z

@tjamet Any updates?

agaudreault · 2024-07-25T16:03:39Z

docs/operator-manual/argocd-cm.yaml

+  # Additional externally facing base URLs (optional)
+  urls: |
+    - https://argo-cd-demo2.argoproj.io
+


I think the feature must be documented in the ArgoCD argo-cd.readthedocs.io/en/stable/operator-manual/user-management documentation.

Added some short documentation in the user-management doc

agaudreault · 2024-07-25T16:20:03Z

util/oidc/oidc.go

 	}
+	redirectURL, err := a.settings.RedirectURLForRequest(request)
+	if err != nil {
+		redirectURL = a.redirectURI


Probably missing a log.Warnf("unable to find ArgoCD URL from request: %v", err)

Added warning.

agaudreault · 2024-07-25T16:40:34Z

docs/operator-manual/argocd-cm.yaml

  url: https://argo-cd-demo.argoproj.io

+  # Additional externally facing base URLs (optional)
+  urls: |


To provide feature parity, Dex should be configured to use all the urls as valid redirectUrls in

argo-cd/util/dex/config.go

Lines 62 to 64 in fe9aa54

"redirectURIs": []string{

redirectURL,

},

and reload the config when fields are modified. Not sure if that will fully work because you can have multiple urls only between argo<->dex, but it seems only one is supported by dex between dex<->idp. If it does not, perhaps moving that config tooidc.config will be better.

I think I've updated dex to at least load the additional URLs with the proper callback endpoint appended.

I've also handled config reload when settings.AdditionalURLs is modified.

agaudreault · 2024-07-25T16:41:52Z

docs/operator-manual/argocd-cm.yaml

  url: https://argo-cd-demo.argoproj.io

+  # Additional externally facing base URLs (optional)
+  urls: |


Since this field does not replace the url field, I think it will be clearer if it is renamed to additionalUrls

tjamet · 2024-07-29T08:18:20Z

@tjamet Any updates?

Taking a second look, indeed, URL is used to register in dex, and the update to replace by the new proposed list is not that trivial.

Eventually, a decision to deprecate the url config in favour of a list could be taken in the future

Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com>

codeql restricts logging fields from user input. Remove log to avoid complex escapes Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com>

Currently, the documented configmap is invalid and raises error at the time of applying it. Ensure the configmap is valid with a unit test Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com>

Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com>

With HTTP servers, the `url` field of `http.Requests` does not contain the host nor the protocol. To work around this, consider `request.Host` and `request.URL.RequestURI()` Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com>

Currently, while login is correctly handled, when logging out from an alternate URL, we are redirected to the main URL. Fix this by applying the same principles as for the login part Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com>

Signed-off-by: Clif Houck <me@clifhouck.com>

…other spots in the codebase Signed-off-by: Clif Houck <me@clifhouck.com>

Signed-off-by: Clif Houck <me@clifhouck.com>

ClifHouck · 2024-07-29T17:45:32Z

I believe I've addressed everything brought up so far, and re-based on latest master e2c5a55 for good measure. Not sure what to do about the linter failing on files I haven't changed.

ClifHouck · 2024-07-29T17:46:41Z

Also need guidance on what to do about the license compliance check.

agaudreault · 2024-07-29T21:03:31Z

Also need guidance on what to do about the license compliance check.

@ClifHouck You can ignore that.

agaudreault

LGTM. Added in my sprint to give it a try internally, for both dex and native oidc. I should be able to test tomorrow.

ClifHouck · 2024-07-29T21:12:36Z

LGTM. Added in my sprint to give it a try internally, for both dex and native oidc. I should be able to test tomorrow.

Thank you!

docs/operator-manual/argocd-cm.yaml

Correct misspelling of additionalUrls Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Clif Houck <me@clifhouck.com>

agaudreault · 2024-07-30T18:23:31Z

@ClifHouck Have you tested this image on an actual deployment? I am getting constant Invalid redirect URL: the protocol and host (including port) must match and the path must be within allowed URLs if provided. Might be a configuration problem on my part, but everything looks as expected. I am testing with the native oidc auth.

ClifHouck · 2024-07-30T18:40:08Z

@ClifHouck Have you tested this image on an actual deployment? I am getting constant Invalid redirect URL: the protocol and host (including port) must match and the path must be within allowed URLs if provided. Might be a configuration problem on my part, but everything looks as expected. I am testing with the native oidc auth.

No, but I thought the included additional tests of the original PR would've covered this case. I'll setup an environment to do more in-depth testing. I may not be able to complete this before leaving for vacation though. I'll be back online on August 12th.

agaudreault

Using the correct value from config, it is working for dex+oidc and native oidc. 🎉

util/settings/settings.go

Fix incorrect key for additionalUrls Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Clif Houck <me@clifhouck.com>

Fix key name Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Clif Houck <me@clifhouck.com>

Signed-off-by: Clif Houck <me@clifhouck.com>

agaudreault

Lgtm @ishitasequeira

ishitasequeira

Thanks @ClifHouck for the PR!! and Thanks @agaudreault for the review!!

alexmt

LGTM

* Add new field to the documentation Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com> * Fix codeql issue codeql restricts logging fields from user input. Remove log to avoid complex escapes Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com> * Add a test to ensure validity of the documented cm Currently, the documented configmap is invalid and raises error at the time of applying it. Ensure the configmap is valid with a unit test Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com> * rename additionalURLs for URLs Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com> * Allow responses redirected from SSO to alternate URLs Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com> * Consider dex enabled when there are additional URLs configured Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com> * Parse new URLs config from argocd-cm Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com> * Detect additional SSO URLs from requests With HTTP servers, the `url` field of `http.Requests` does not contain the host nor the protocol. To work around this, consider `request.Host` and `request.URL.RequestURI()` Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com> * Handle logout properly Currently, while login is correctly handled, when logging out from an alternate URL, we are redirected to the main URL. Fix this by applying the same principles as for the login part Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com> * Fix ClientApp.oath2Config Signed-off-by: Clif Houck <me@clifhouck.com> * Fix test compile time error Signed-off-by: Clif Houck <me@clifhouck.com> * Fix TestDocumentedArgoCDConfigMapIsValid to parse in the same way as other spots in the codebase Signed-off-by: Clif Houck <me@clifhouck.com> * Fix warning messages for external URLs when attemping to load them from config map Signed-off-by: Clif Houck <me@clifhouck.com> * Revert change to IsDexConfigured since Dex does not use URLs setting Signed-off-by: Clif Houck <me@clifhouck.com> * Remove unnecessary receiver nil check in favor of fixing test Signed-off-by: Clif Houck <me@clifhouck.com> * Fix typo Signed-off-by: Clif Houck <me@clifhouck.com> * Add a unit test for RedirectURLForRequest Signed-off-by: Clif Houck <me@clifhouck.com> * Rename settings.URLs to AdditionalURLs Signed-off-by: Clif Houck <me@clifhouck.com> * Fix use of URLs in TestClientApp_HandleLogin Signed-off-by: Clif Houck <me@clifhouck.com> * Renamed urls to additionalUrls Signed-off-by: Clif Houck <me@clifhouck.com> * Integrate settings.AdditionalURLs with dex config and test settings.RedirectAdditionalURLs Signed-off-by: Clif Houck <me@clifhouck.com> * Reload ArgoCDServer when settings.AdditionalURLs changes Signed-off-by: Clif Houck <me@clifhouck.com> * Add note about additionalUrls to user-managament docs Signed-off-by: Clif Houck <me@clifhouck.com> * Add G-Research Signed-off-by: Clif Houck <me@clifhouck.com> * Change G-Research URL to point to open-source page Signed-off-by: Clif Houck <me@clifhouck.com> * Update docs/operator-manual/argocd-cm.yaml Correct misspelling of additionalUrls Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Clif Houck <me@clifhouck.com> * Update util/settings/settings.go Fix incorrect key for additionalUrls Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Clif Houck <me@clifhouck.com> * Update util/settings/settings.go Fix key name Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Clif Houck <me@clifhouck.com> * fix additional urls config key in test config Signed-off-by: Clif Houck <me@clifhouck.com> --------- Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com> Co-authored-by: Thibault Jamet <tjamet@users.noreply.github.com> Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* Add new field to the documentation Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com> * Fix codeql issue codeql restricts logging fields from user input. Remove log to avoid complex escapes Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com> * Add a test to ensure validity of the documented cm Currently, the documented configmap is invalid and raises error at the time of applying it. Ensure the configmap is valid with a unit test Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com> * rename additionalURLs for URLs Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com> * Allow responses redirected from SSO to alternate URLs Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com> * Consider dex enabled when there are additional URLs configured Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com> * Parse new URLs config from argocd-cm Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com> * Detect additional SSO URLs from requests With HTTP servers, the `url` field of `http.Requests` does not contain the host nor the protocol. To work around this, consider `request.Host` and `request.URL.RequestURI()` Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com> * Handle logout properly Currently, while login is correctly handled, when logging out from an alternate URL, we are redirected to the main URL. Fix this by applying the same principles as for the login part Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com> * Fix ClientApp.oath2Config Signed-off-by: Clif Houck <me@clifhouck.com> * Fix test compile time error Signed-off-by: Clif Houck <me@clifhouck.com> * Fix TestDocumentedArgoCDConfigMapIsValid to parse in the same way as other spots in the codebase Signed-off-by: Clif Houck <me@clifhouck.com> * Fix warning messages for external URLs when attemping to load them from config map Signed-off-by: Clif Houck <me@clifhouck.com> * Revert change to IsDexConfigured since Dex does not use URLs setting Signed-off-by: Clif Houck <me@clifhouck.com> * Remove unnecessary receiver nil check in favor of fixing test Signed-off-by: Clif Houck <me@clifhouck.com> * Fix typo Signed-off-by: Clif Houck <me@clifhouck.com> * Add a unit test for RedirectURLForRequest Signed-off-by: Clif Houck <me@clifhouck.com> * Rename settings.URLs to AdditionalURLs Signed-off-by: Clif Houck <me@clifhouck.com> * Fix use of URLs in TestClientApp_HandleLogin Signed-off-by: Clif Houck <me@clifhouck.com> * Renamed urls to additionalUrls Signed-off-by: Clif Houck <me@clifhouck.com> * Integrate settings.AdditionalURLs with dex config and test settings.RedirectAdditionalURLs Signed-off-by: Clif Houck <me@clifhouck.com> * Reload ArgoCDServer when settings.AdditionalURLs changes Signed-off-by: Clif Houck <me@clifhouck.com> * Add note about additionalUrls to user-managament docs Signed-off-by: Clif Houck <me@clifhouck.com> * Add G-Research Signed-off-by: Clif Houck <me@clifhouck.com> * Change G-Research URL to point to open-source page Signed-off-by: Clif Houck <me@clifhouck.com> * Update docs/operator-manual/argocd-cm.yaml Correct misspelling of additionalUrls Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Clif Houck <me@clifhouck.com> * Update util/settings/settings.go Fix incorrect key for additionalUrls Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Clif Houck <me@clifhouck.com> * Update util/settings/settings.go Fix key name Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Clif Houck <me@clifhouck.com> * fix additional urls config key in test config Signed-off-by: Clif Houck <me@clifhouck.com> --------- Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com> Co-authored-by: Thibault Jamet <tjamet@users.noreply.github.com> Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Rhys Williams <rhys.williams@electrum.co.za>

akloss-cibo · 2024-09-05T15:36:40Z

Any thoughts about when this will be in a tagged release?

dave-gantenbein · 2024-10-22T13:54:22Z

@ishitasequeira - we could really use a tagged release that contains this change, any idea when that might happen?

blakepettersson · 2024-10-22T13:58:26Z

This will be in 2.13.

ClifHouck requested review from a team as code owners July 3, 2024 22:09

ClifHouck mentioned this pull request Jul 3, 2024

feat: Allow multiple extenal URLs for SSO access #14208

Closed

13 tasks

ClifHouck marked this pull request as draft July 4, 2024 15:02

ClifHouck force-pushed the clif/tjamet/multiple-url-external-sso branch from 9c0c3ee to 9f64a90 Compare July 8, 2024 21:04

ClifHouck commented Jul 9, 2024

View reviewed changes

ClifHouck marked this pull request as ready for review July 12, 2024 18:04

agaudreault requested changes Jul 25, 2024

View reviewed changes

ClifHouck changed the title ~~feat: Allow multiple external URLs for SSO access~~ feat(5388): Allow multiple external URLs for SSO access Jul 29, 2024

tjamet and others added 12 commits July 29, 2024 12:25

Add new field to the documentation

4d13f54

Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com>

Fix codeql issue

f5860d6

codeql restricts logging fields from user input. Remove log to avoid complex escapes Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com>

rename additionalURLs for URLs

4d06ed0

Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com>

Allow responses redirected from SSO to alternate URLs

d424caf

Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com>

Consider dex enabled when there are additional URLs configured

8a8917b

Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com>

Parse new URLs config from argocd-cm

98a9b3c

Signed-off-by: Thibault Jamet <tjamet@users.noreply.github.com> Signed-off-by: Clif Houck <me@clifhouck.com>

Fix ClientApp.oath2Config

3026d47

Signed-off-by: Clif Houck <me@clifhouck.com>

Fix test compile time error

7c400e7

Signed-off-by: Clif Houck <me@clifhouck.com>

Fix TestDocumentedArgoCDConfigMapIsValid to parse in the same way as …

670dc33

…other spots in the codebase Signed-off-by: Clif Houck <me@clifhouck.com>

Change G-Research URL to point to open-source page

9c0c570

Signed-off-by: Clif Houck <me@clifhouck.com>

ClifHouck requested a review from agaudreault July 29, 2024 17:45

agaudreault reviewed Jul 29, 2024

View reviewed changes

agaudreault reviewed Jul 30, 2024

View reviewed changes

docs/operator-manual/argocd-cm.yaml Outdated Show resolved Hide resolved

Update docs/operator-manual/argocd-cm.yaml

f4c24b4

Correct misspelling of additionalUrls Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Clif Houck <me@clifhouck.com>

agaudreault requested changes Jul 30, 2024

View reviewed changes

util/settings/settings.go Outdated Show resolved Hide resolved

agaudreault reviewed Jul 30, 2024

View reviewed changes

util/settings/settings.go Outdated Show resolved Hide resolved

ClifHouck and others added 3 commits July 30, 2024 15:21

Update util/settings/settings.go

04353a5

Fix incorrect key for additionalUrls Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Clif Houck <me@clifhouck.com>

Update util/settings/settings.go

6b5f626

Fix key name Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Clif Houck <me@clifhouck.com>

fix additional urls config key in test config

79555cd

Signed-off-by: Clif Houck <me@clifhouck.com>

agaudreault approved these changes Jul 30, 2024

View reviewed changes

ishitasequeira approved these changes Jul 30, 2024

View reviewed changes

ishitasequeira enabled auto-merge (squash) July 30, 2024 22:18

ishitasequeira merged commit 42de68d into argoproj:master Jul 30, 2024

agaudreault mentioned this pull request Jul 31, 2024

REQUEST: Promotion to Approver for @agaudreault argoproj/argoproj#310

Closed

6 tasks

alexmt reviewed Jul 31, 2024

View reviewed changes

agaudreault mentioned this pull request Sep 19, 2024

Allow providing multiple external URLs in ArgoCD config #8354

Closed

Huckletoon mentioned this pull request Jun 13, 2025

Grafana OAuth2 authentication support dynamic multiple domain as redirect_uri grafana/grafana#80334

Open

Conversation

ClifHouck commented Jul 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bunnyshell bot commented Jul 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Preview Environment deleted from Bunnyshell

Uh oh!

bunnyshell bot commented Jul 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Preview Environment deleted from Bunnyshell

Uh oh!

agaudreault commented Jul 4, 2024

Uh oh!

codecov bot commented Jul 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ClifHouck left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ClifHouck commented Jul 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ClifHouck commented Jul 9, 2024

Uh oh!

tjamet commented Jul 14, 2024

Uh oh!

ClifHouck commented Jul 22, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

agaudreault Jul 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tjamet commented Jul 29, 2024

Uh oh!

ClifHouck commented Jul 29, 2024

Uh oh!

ClifHouck commented Jul 29, 2024

Uh oh!

agaudreault commented Jul 29, 2024

Uh oh!

agaudreault left a comment

Choose a reason for hiding this comment

Uh oh!

ClifHouck commented Jul 29, 2024

Uh oh!

Uh oh!

agaudreault commented Jul 30, 2024

Uh oh!

ClifHouck commented Jul 30, 2024

Uh oh!

agaudreault left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

agaudreault left a comment

Choose a reason for hiding this comment

Uh oh!

ishitasequeira left a comment

ClifHouck commented Jul 3, 2024 •

edited

Loading

bunnyshell bot commented Jul 3, 2024 •

edited

Loading

bunnyshell bot commented Jul 3, 2024 •

edited

Loading

codecov bot commented Jul 8, 2024 •

edited

Loading

ClifHouck commented Jul 9, 2024 •

edited

Loading

agaudreault Jul 25, 2024 •

edited

Loading

agaudreault left a comment •

edited

Loading