feat(core): added EndpointSlice in ignoredRefreshResources (issue: #18857 )#18876
feat(core): added EndpointSlice in ignoredRefreshResources (issue: #18857 )#18876AnkurManna wants to merge 2 commits intoargoproj:masterfrom
Conversation
Signed-off-by: Ankur Manna <ankurma@Ankurs-MacBook-Air.local>
❗ Preview Environment undeploy from Bunnyshell failedSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
✅ Preview Environment created on Bunnyshell but will not be auto-deployedSee: Environment Details Available commands (reply to this comment):
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18876 +/- ##
=======================================
Coverage 50.58% 50.59%
=======================================
Files 315 315
Lines 43197 43197
=======================================
+ Hits 21852 21854 +2
+ Misses 18847 18845 -2
Partials 2498 2498 ☔ View full report in Codecov by Sentry. |
| serviceDiscoveryGroup = "discovery.k8s.io" | ||
| serviceDiscoveryEndpointSliceKind = "EndpointSlice" |
There was a problem hiding this comment.
It is already possible to configure which resources update to ignore with customizations. https://argo-cd.readthedocs.io/en/stable/operator-manual/reconcile/ . Have you tried to use this feature?
Additionally, if you do not manage EndpointSlice manually, you can fully omit them from the watched resources. https://argo-cd.readthedocs.io/en/stable/operator-manual/declarative-setup/#resource-exclusioninclusion
There was a problem hiding this comment.
I did that exclusion via resource updates rule. However, I think it's something everyone should do, thus having them hard-coded seems beneficial.
argo-cd issue: #18857
Checklist: