Skip to content

feat(core): added EndpointSlice in ignoredRefreshResources (issue: #18857 )#18876

Open
AnkurManna wants to merge 2 commits intoargoproj:masterfrom
AnkurManna:enhancement/skip-reconciliation-endpointslice
Open

feat(core): added EndpointSlice in ignoredRefreshResources (issue: #18857 )#18876
AnkurManna wants to merge 2 commits intoargoproj:masterfrom
AnkurManna:enhancement/skip-reconciliation-endpointslice

Conversation

@AnkurManna
Copy link
Copy Markdown

@AnkurManna AnkurManna commented Jul 1, 2024

argo-cd issue: #18857

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Ankur Manna <ankurma@Ankurs-MacBook-Air.local>
@AnkurManna AnkurManna requested a review from a team as a code owner July 1, 2024 15:14
@bunnyshell
Copy link
Copy Markdown

bunnyshell bot commented Jul 1, 2024

❗ Preview Environment undeploy from Bunnyshell failed

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to try again to remove the environment

@bunnyshell
Copy link
Copy Markdown

bunnyshell bot commented Jul 1, 2024

✅ Preview Environment created on Bunnyshell but will not be auto-deployed

See: Environment Details

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@AnkurManna AnkurManna changed the title feat(core): added EndpointSlice in ignoredRefreshResources (issue: https://github.com/argoproj/argo-cd/issues/18857 ) feat(core): added EndpointSlice in ignoredRefreshResources (issue: 18857 ) Jul 1, 2024
@AnkurManna AnkurManna changed the title feat(core): added EndpointSlice in ignoredRefreshResources (issue: 18857 ) feat(core): added EndpointSlice in ignoredRefreshResources (issue: #18857 ) Jul 1, 2024
Copy link
Copy Markdown
Contributor

@andrii-korotkov-verkada andrii-korotkov-verkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 1, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.59%. Comparing base (c6f96d7) to head (37f2160).
⚠️ Report is 3514 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #18876   +/-   ##
=======================================
  Coverage   50.58%   50.59%           
=======================================
  Files         315      315           
  Lines       43197    43197           
=======================================
+ Hits        21852    21854    +2     
+ Misses      18847    18845    -2     
  Partials     2498     2498           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev requested a review from agaudreault July 2, 2024 18:48
Comment thread controller/cache/cache.go
Comment on lines +107 to +108
serviceDiscoveryGroup = "discovery.k8s.io"
serviceDiscoveryEndpointSliceKind = "EndpointSlice"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already possible to configure which resources update to ignore with customizations. https://argo-cd.readthedocs.io/en/stable/operator-manual/reconcile/ . Have you tried to use this feature?

Additionally, if you do not manage EndpointSlice manually, you can fully omit them from the watched resources. https://argo-cd.readthedocs.io/en/stable/operator-manual/declarative-setup/#resource-exclusioninclusion

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that exclusion via resource updates rule. However, I think it's something everyone should do, thus having them hard-coded seems beneficial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants