feat(rbac): fine-grained update/delete for application resources#18124
Merged
leoluz merged 16 commits intoargoproj:masterfrom May 13, 2024
Merged
feat(rbac): fine-grained update/delete for application resources#18124leoluz merged 16 commits intoargoproj:masterfrom
leoluz merged 16 commits intoargoproj:masterfrom
Conversation
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
…go-cd into rbac-granular-delete
agaudreault
requested review from
alexmt,
crenshaw-dev,
csantanapr,
jannfis,
leoluz and
todaywasawesome
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
leoluz
requested changes
May 10, 2024
Collaborator
leoluz
left a comment
leoluz
left a comment
There was a problem hiding this comment.
Please check my comments
leoluz
requested changes
May 10, 2024
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
leoluz
reviewed
May 13, 2024
agaudreault
commented
May 13, 2024
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
mkieweg
pushed a commit
to mkieweg/argo-cd
that referenced
this pull request
Jun 11, 2024
…oproj#18124) * feat(rbac): fine-grained update/delete for application resources Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * rewrite rbac (draft) Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * add other stuff Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * spellcheck Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * update map Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * spell check Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * linter not happy about deprecated claims Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * not happy about claims at all Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * generated Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * fix list syntax Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * use same link pattern Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * rewrite permissions to policy when it applies Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * Update docs/operator-manual/rbac.md Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> --------- Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
…oproj#18124) * feat(rbac): fine-grained update/delete for application resources Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * rewrite rbac (draft) Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * add other stuff Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * spellcheck Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * update map Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * spell check Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * linter not happy about deprecated claims Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * not happy about claims at all Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * generated Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * fix list syntax Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * use same link pattern Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * rewrite permissions to policy when it applies Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * Update docs/operator-manual/rbac.md Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> --------- Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
|
Looks like the milestone is not updated https://github.com/argoproj/argo-cd/milestone/34 Can you please help to update the milestone? |
jsolana
pushed a commit
to jsolana/argo-cd
that referenced
this pull request
Jul 24, 2024
…oproj#18124) * feat(rbac): fine-grained update/delete for application resources Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * rewrite rbac (draft) Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * add other stuff Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * spellcheck Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * update map Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * spell check Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * linter not happy about deprecated claims Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * not happy about claims at all Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * generated Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * fix list syntax Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * use same link pattern Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * rewrite permissions to policy when it applies Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * Update docs/operator-manual/rbac.md Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> --------- Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Javier Solana <javier.solana@cabify.com> Signed-off-by: Javier Solana <javier.solana@cabify.com>
fffinkel
added a commit
to fffinkel/argo-cd
that referenced
this pull request
Nov 4, 2024
Change applications resource RBAC to use fine-grained update/delete enforcement by default. This allows us to enforce RBAC on the application itself, separately from the sub-resources related to it. See also GitHub argoproj#18124, argoproj#20600
fffinkel
added a commit
to fffinkel/argo-cd
that referenced
this pull request
Nov 5, 2024
Change applications resource RBAC to use fine-grained update/delete enforcement by default. This allows us to enforce RBAC on the application itself, separately from the sub-resources related to it. See also GitHub argoproj#18124, argoproj#20600
fffinkel
added a commit
to fffinkel/argo-cd
that referenced
this pull request
Nov 5, 2024
…oj#19988) Change applications resource RBAC to use fine-grained update/delete enforcement by default. This allows us to enforce RBAC on the application itself, separately from the sub-resources related to it. (see also argoproj#18124, argoproj#20600)
fffinkel
added a commit
to fffinkel/argo-cd
that referenced
this pull request
Nov 5, 2024
A breaking change was introduced in a previous commit that is planned to be a part of the next major version of Argo CD (v3) where it's okay to introduce breaking changes. We want this feature before we hit v3, so we add a config setting that allows us to explicitly turn this new v3 behavior on in v2. The current v2 behavior is the default, so this change will not affect folks who do not explicitly opt in. This commit to add the gating code is added separately so it will be easy to either cherry pick that pervious commit or revert this one. (see also argoproj#18124, argoproj#20600)
fffinkel
added a commit
to fffinkel/argo-cd
that referenced
this pull request
Nov 5, 2024
…oj#19988) Change applications resource RBAC to use fine-grained update/delete enforcement by default. This allows us to enforce RBAC on the application itself, separately from the sub-resources related to it. (see also argoproj#18124, argoproj#20600) Signed-off-by: Matt Finkel <finkel.matt@gmail.com>
fffinkel
added a commit
to fffinkel/argo-cd
that referenced
this pull request
Nov 5, 2024
A breaking change was introduced in a previous commit that is planned to be a part of the next major version of Argo CD (v3) where it's okay to introduce breaking changes. We want this feature before we hit v3, so we add a config setting that allows us to explicitly turn this new v3 behavior on in v2. The current v2 behavior is the default, so this change will not affect folks who do not explicitly opt in. This commit to add the gating code is added separately so it will be easy to either cherry pick that pervious commit or revert this one. (see also argoproj#18124, argoproj#20600) Signed-off-by: Matt Finkel <finkel.matt@gmail.com>
fffinkel
added a commit
to fffinkel/argo-cd
that referenced
this pull request
Nov 5, 2024
…oj#19988) Change applications resource RBAC to use fine-grained update/delete enforcement by default. This allows us to enforce RBAC on the application itself, separately from the sub-resources related to it. (see also argoproj#18124, argoproj#20600) Signed-off-by: Matt Finkel <finkel.matt@gmail.com>
fffinkel
added a commit
to fffinkel/argo-cd
that referenced
this pull request
Nov 5, 2024
A breaking change was introduced in a previous commit that is planned to be a part of the next major version of Argo CD (v3) where it's okay to introduce breaking changes. We want this feature before we hit v3, so we add a config setting that allows us to explicitly turn this new v3 behavior on in v2. The current v2 behavior is the default, so this change will not affect folks who do not explicitly opt in. This commit to add the gating code is added separately so it will be easy to either cherry pick that pervious commit or revert this one. (see also argoproj#18124, argoproj#19988) Signed-off-by: Matt Finkel <finkel.matt@gmail.com>
fffinkel
added a commit
to fffinkel/argo-cd
that referenced
this pull request
Nov 5, 2024
A breaking change was introduced in a previous commit that is planned to be a part of the next major version of Argo CD (v3) where it's okay to introduce breaking changes. We want this feature before we hit v3, so we add a config setting that allows us to explicitly turn this new v3 behavior on in v2. The current v2 behavior is the default, so this change will not affect folks who do not explicitly opt in. This commit to add the gating code is added separately so it will be easy to either cherry pick that pervious commit or revert this one. (see also argoproj#18124, argoproj#19988) Signed-off-by: Matt Finkel <finkel.matt@gmail.com>
fffinkel
added a commit
to fffinkel/argo-cd
that referenced
this pull request
Nov 5, 2024
…oj#19988) Change applications resource RBAC to use fine-grained update/delete enforcement by default. This allows us to enforce RBAC on the application itself, separately from the sub-resources related to it. (see also argoproj#18124, argoproj#20600) Signed-off-by: Matt Finkel <finkel.matt@gmail.com>
fffinkel
added a commit
to fffinkel/argo-cd
that referenced
this pull request
Nov 5, 2024
A breaking change was introduced in a previous commit that is planned to be a part of the next major version of Argo CD (v3) where it's okay to introduce breaking changes. We want this feature before we hit v3, so we add a config setting that allows us to explicitly turn this new v3 behavior on in v2. The current v2 behavior is the default, so this change will not affect folks who do not explicitly opt in. This commit to add the gating code is added separately so it will be easy to either cherry pick that pervious commit or revert this one. (see also argoproj#18124, argoproj#19988) Signed-off-by: Matt Finkel <finkel.matt@gmail.com>
fffinkel
added a commit
to fffinkel/argo-cd
that referenced
this pull request
Jan 7, 2025
…j#20600) We don't know if this will go out with v3, and furthermore, the name is not very descriptive. (see also argoproj#18124, argoproj#19988) Signed-off-by: Matt Finkel <finkel.matt@gmail.com>
fffinkel
added a commit
to fffinkel/argo-cd
that referenced
this pull request
Jan 8, 2025
…oj#19988) Change applications resource RBAC to use fine-grained update/delete enforcement by default. This allows us to enforce RBAC on the application itself, separately from the sub-resources related to it. (see also argoproj#18124, argoproj#20600) Signed-off-by: Matt Finkel <finkel.matt@gmail.com>
fffinkel
added a commit
to fffinkel/argo-cd
that referenced
this pull request
Jan 8, 2025
A breaking change was introduced in a previous commit that is planned to be a part of the next major version of Argo CD (v3) where it's okay to introduce breaking changes. We want this feature before we hit v3, so we add a config setting that allows us to explicitly turn this new v3 behavior on in v2. The current v2 behavior is the default, so this change will not affect folks who do not explicitly opt in. This commit to add the gating code is added separately so it will be easy to either cherry pick that pervious commit or revert this one. (see also argoproj#18124, argoproj#19988) Signed-off-by: Matt Finkel <finkel.matt@gmail.com>
fffinkel
added a commit
to fffinkel/argo-cd
that referenced
this pull request
Jan 8, 2025
…j#20600) We don't know if this will go out with v3, and furthermore, the name is not very descriptive. (see also argoproj#18124, argoproj#19988) Signed-off-by: Matt Finkel <finkel.matt@gmail.com>
fffinkel
added a commit
to fffinkel/argo-cd
that referenced
this pull request
Jan 8, 2025
A breaking change was introduced in a previous commit that is planned to be a part of the next major version of Argo CD (v3) where it's okay to introduce breaking changes. We want this feature before we hit v3, so we add a config setting that allows us to explicitly turn this new v3 behavior on in v2. The current v2 behavior is the default, so this change will not affect folks who do not explicitly opt in. This commit to add the gating code is added separately so it will be easy to either cherry pick that pervious commit or revert this one. (see also argoproj#18124, argoproj#19988) Signed-off-by: Matt Finkel <finkel.matt@gmail.com>
fffinkel
added a commit
to fffinkel/argo-cd
that referenced
this pull request
Jan 8, 2025
…oj#19988) Change applications resource RBAC to use fine-grained update/delete enforcement by default. This allows us to enforce RBAC on the application itself, separately from the sub-resources related to it. (see also argoproj#18124, argoproj#20600) Signed-off-by: Matt Finkel <finkel.matt@gmail.com>
fffinkel
added a commit
to fffinkel/argo-cd
that referenced
this pull request
Jan 8, 2025
A breaking change was introduced in a previous commit that is planned to be a part of the next major version of Argo CD (v3) where it's okay to introduce breaking changes. We want this feature before we hit v3, so we add a config setting that allows us to explicitly turn this new v3 behavior on in v2. The current v2 behavior is the default, so this change will not affect folks who do not explicitly opt in. This commit to add the gating code is added separately so it will be easy to either cherry pick that pervious commit or revert this one. (see also argoproj#18124, argoproj#19988) Signed-off-by: Matt Finkel <finkel.matt@gmail.com>
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17991
Closes #12777
Closes #3593
Closes #14379
Task to do
Screen.Recording.2024-05-08.at.3.50.15.PM.mov
Checklist: