feat: add support for defining a custom list of ssh key exchange algorithms.#18007
Open
Gottox wants to merge 4 commits intoargoproj:masterfrom
Open
feat: add support for defining a custom list of ssh key exchange algorithms.#18007Gottox wants to merge 4 commits intoargoproj:masterfrom
Gottox wants to merge 4 commits intoargoproj:masterfrom
Conversation
17a504e to
2ff5ab8
Compare
3 tasks
Contributor
|
@jannfis Would you mind taking a look? Anything that touches encryption needs lots of 👀 |
Contributor
@todaywasawesome @jannfis please read the complete linked issue, there is a lot of troubleshooting in there. While this change is useful I don't believe it addresses the immediate blocker people are experiencing. |
Member
Author
|
I leave that open, as it may be useful anyway. |
Fixes argoproj#17634 Signed-off-by: Enno Boland <g@s01.de>
Signed-off-by: Enno Boland <g@s01.de>
Signed-off-by: Enno Boland <g@s01.de>
e0ef67e to
a1b3e1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on a quickfix from @zamedic, I implemented a feature that allows to define custom SSH key exchange algorithms in ArgoCD.
Allows to workaround issue #17634
Checklist:
This PR adds a feature to define custom ssh key exchange algorithms. This is needed to fix #17634.
This is a first proposal and hasn't been tested in depth yet.