Skip to content

docs: fix metrics labels name in notification monitoring#17869

Merged
pasha-codefresh merged 2 commits intoargoproj:masterfrom
adevinta:fix-metrics-label-name
Apr 17, 2024
Merged

docs: fix metrics labels name in notification monitoring#17869
pasha-codefresh merged 2 commits intoargoproj:masterfrom
adevinta:fix-metrics-label-name

Conversation

@dacofr
Copy link
Contributor

@dacofr dacofr commented Apr 17, 2024

This PR fix notification documentation which use wrong labels name in argocd_notifications_deliveries_total metric
Possible labels are defined here https://github.com/argoproj/notifications-engine/blob/master/pkg/controller/metrics.go#L16

func NewMetricsRegistry(prefix string) *MetricsRegistry {
	deliveriesCounter := prometheus.NewCounterVec(
		prometheus.CounterOpts{
			Name: fmt.Sprintf("%s_notifications_deliveries_total", prefix),
			Help: "Number of delivered notifications.",
		},
		[]string{"trigger", "service", "succeeded"},
	)
     ...
}

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@dacofr dacofr requested review from a team as code owners April 17, 2024 10:23
Signed-off-by: philippe.dacosta <philippe.dacosta@adevinta.com>
@dacofr dacofr force-pushed the fix-metrics-label-name branch from cc417d3 to 309a641 Compare April 17, 2024 10:44
Copy link
Member

@pasha-codefresh pasha-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you

@pasha-codefresh pasha-codefresh merged commit 1c6b6eb into argoproj:master Apr 17, 2024
mkieweg pushed a commit to mkieweg/argo-cd that referenced this pull request Jun 11, 2024
)

Signed-off-by: philippe.dacosta <philippe.dacosta@adevinta.com>
Co-authored-by: philippe.dacosta <philippe.dacosta@adevinta.com>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
)

Signed-off-by: philippe.dacosta <philippe.dacosta@adevinta.com>
Co-authored-by: philippe.dacosta <philippe.dacosta@adevinta.com>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
@dacofr dacofr deleted the fix-metrics-label-name branch July 5, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants