docs: fix metrics labels name in notification monitoring#17869
Merged
pasha-codefresh merged 2 commits intoargoproj:masterfrom Apr 17, 2024
Merged
docs: fix metrics labels name in notification monitoring#17869pasha-codefresh merged 2 commits intoargoproj:masterfrom
pasha-codefresh merged 2 commits intoargoproj:masterfrom
Conversation
Signed-off-by: philippe.dacosta <philippe.dacosta@adevinta.com>
cc417d3 to
309a641
Compare
pasha-codefresh
approved these changes
Apr 17, 2024
Member
pasha-codefresh
left a comment
There was a problem hiding this comment.
Good catch, thank you
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix notification documentation which use wrong labels name in
argocd_notifications_deliveries_totalmetricPossible labels are defined here https://github.com/argoproj/notifications-engine/blob/master/pkg/controller/metrics.go#L16
Checklist: