Skip to content

chore: native client mock should be generated with go gen #17864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ishitasequeira merged 5 commits into from
Apr 16, 2024
Merged

chore: native client mock should be generated with go gen #17864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9ef6404
fix: native client mock should be generated with go gen
pasha-codefresh Apr 16, 2024
1494c0f
fix: native client mock should be generated with go gen
pasha-codefresh Apr 16, 2024
39c8d8c
Merge remote-tracking branch 'origin/feat/native-git-client-codegen' …
pasha-codefresh Apr 16, 2024
de00e19
fix: native client mock should be generated with go gen
pasha-codefresh Apr 16, 2024
1d8af34
adopt repository_test.go to new helm mock client
pasha-codefresh Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions reposerver/repository/repository_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@ func newServiceWithMocks(t *testing.T, root string, signed bool) (*Service, *git
chart: {{Version: "1.0.0"}, {Version: version}},
oobChart: {{Version: "1.0.0"}, {Version: version}},
}}, nil)
helmClient.On("ExtractChart", chart, version).Return("./testdata/my-chart", io.NopCloser, nil)
helmClient.On("ExtractChart", oobChart, version).Return("./testdata2/out-of-bounds-chart", io.NopCloser, nil)
helmClient.On("ExtractChart", chart, version, false, int64(0), false).Return("./testdata/my-chart", io.NopCloser, nil)
helmClient.On("ExtractChart", oobChart, version, false, int64(0), false).Return("./testdata2/out-of-bounds-chart", io.NopCloser, nil)
helmClient.On("CleanChartCache", chart, version).Return(nil)
helmClient.On("CleanChartCache", oobChart, version).Return(nil)
helmClient.On("DependencyBuild").Return(nil)
Expand Down
2 changes: 2 additions & 0 deletions util/helm/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ import (
"github.com/argoproj/argo-cd/v2/util/proxy"
)

//go:generate go run github.com/vektra/mockery/v2@v2.25.1 --name=Client

var (
globalLock = sync.NewKeyLock()
indexLock = sync.NewKeyLock()
Expand Down
69 changes: 48 additions & 21 deletions util/helm/mocks/Client.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.