Skip to content

fix: run codegen check in ci for docs#17853

Merged
pasha-codefresh merged 1 commit intoargoproj:masterfrom
gdsoumya:fix/doc_ci
Apr 15, 2024
Merged

fix: run codegen check in ci for docs#17853
pasha-codefresh merged 1 commit intoargoproj:masterfrom
gdsoumya:fix/doc_ci

Conversation

@gdsoumya
Copy link
Member

Fixes #17850

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
@gdsoumya gdsoumya requested review from a team as code owners April 15, 2024 19:43
Copy link
Member

@34fathombelow 34fathombelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@pasha-codefresh pasha-codefresh enabled auto-merge (squash) April 15, 2024 20:02
@pasha-codefresh pasha-codefresh merged commit 957170e into argoproj:master Apr 15, 2024
mkieweg pushed a commit to mkieweg/argo-cd that referenced this pull request Jun 11, 2024
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI codegen check step is skipped when changes to docs are made

4 participants