fix(api): use arrays instead of map to display ApplicationManifetQuery fields in swagger#17804
Merged
crenshaw-dev merged 3 commits intoargoproj:masterfrom Apr 12, 2024
ishitasequeira:update-manifest-query-for-swagger
Merged
fix(api): use arrays instead of map to display ApplicationManifetQuery fields in swagger#17804crenshaw-dev merged 3 commits intoargoproj:masterfrom ishitasequeira:update-manifest-query-for-swagger
crenshaw-dev merged 3 commits intoargoproj:masterfrom
ishitasequeira:update-manifest-query-for-swagger
Conversation
…n swagger Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
crenshaw-dev
requested changes
Apr 11, 2024
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
Member
|
/cherry-pick release-2.11 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Apr 12, 2024
…y fields in swagger (#17804) * use arrays instead of map to display ApplicationManifetQuery fields in swagger Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * fix equality conditions for souce-position check Signed-off-by: ishitasequeira <ishiseq29@gmail.com> --------- Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Apr 12, 2024
…y fields in swagger (#17804) (#17820) * use arrays instead of map to display ApplicationManifetQuery fields in swagger * fix equality conditions for souce-position check --------- Signed-off-by: ishitasequeira <ishiseq29@gmail.com> Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
mkieweg
pushed a commit
to mkieweg/argo-cd
that referenced
this pull request
Jun 11, 2024
…y fields in swagger (argoproj#17804) * use arrays instead of map to display ApplicationManifetQuery fields in swagger Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * fix equality conditions for souce-position check Signed-off-by: ishitasequeira <ishiseq29@gmail.com> --------- Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
…y fields in swagger (argoproj#17804) * use arrays instead of map to display ApplicationManifetQuery fields in swagger Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * fix equality conditions for souce-position check Signed-off-by: ishitasequeira <ishiseq29@gmail.com> --------- Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
revisionSourceMappingsdoes not show up on the swagger-ui. The openapigen ignoresmapfields while creating a swagger document. As a fix, we replace map with 2 arrays in theApplicationManifestQueryobject.To be cherry-picked into
release-2.11Updated swagger:
Checklist: