fix: Excessive HTTP requests when navigating in list view - 17756#17757
Merged
pasha-codefresh merged 2 commits intoargoproj:masterfrom Apr 16, 2024
adberger:fix/excessive-http-requests-in-list-view
Merged
fix: Excessive HTTP requests when navigating in list view - 17756#17757pasha-codefresh merged 2 commits intoargoproj:masterfrom adberger:fix/excessive-http-requests-in-list-view
pasha-codefresh merged 2 commits intoargoproj:masterfrom
adberger:fix/excessive-http-requests-in-list-view
Conversation
Contributor
Author
|
@ashutosh16 Do I need to do anything else for a reviewer to look into it? |
Signed-off-by: Adrian Berger <adria.berger94@gmail.com>
Contributor
|
LGTM Screen.Recording.2024-04-09.at.22.46.56.mov |
ashutosh16
approved these changes
Apr 10, 2024
Contributor
|
@ishitasequeira Changes look to me, Can you take a second look at the changes? |
pasha-codefresh
approved these changes
Apr 16, 2024
Member
pasha-codefresh
left a comment
pasha-codefresh
left a comment
There was a problem hiding this comment.
LGTM, thank you for your first contribution!
Contributor
Author
|
@pasha-codefresh Where do I see starting from which version this change will be active? |
mkieweg
pushed a commit
to mkieweg/argo-cd
that referenced
this pull request
Jun 11, 2024
…7757) Signed-off-by: Adrian Berger <adria.berger94@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
…7757) Signed-off-by: Adrian Berger <adria.berger94@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17756
As for tree view renderResourceMenu now should only get triggered when clicking on the resource menu in the list view as well.
Please be careful about the review since this is my first contribution.
If you want to backport it, is up to you to decide.
Checklist: