Skip to content

chore(ui): improve the msg to user when deleteing the resource#17734

Merged
crenshaw-dev merged 1 commit intoargoproj:masterfrom
ashutosh16:fix-usr-msg-when-delete-top-level
Apr 4, 2024
Merged

chore(ui): improve the msg to user when deleteing the resource#17734
crenshaw-dev merged 1 commit intoargoproj:masterfrom
ashutosh16:fix-usr-msg-when-delete-top-level

Conversation

@ashutosh16
Copy link
Copy Markdown
Contributor

Recently, some users unintentionally deleted the resource, and in order to prevent similar issues in the future, improve the message to end users;

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
@ashutosh16 ashutosh16 requested a review from a team as a code owner April 4, 2024 19:00
@ashutosh16 ashutosh16 changed the title chores: improve the msg to user when deleteing the resource chore(ui): improve the msg to user when deleteing the resource Apr 4, 2024
@crenshaw-dev crenshaw-dev merged commit 6523f25 into argoproj:master Apr 4, 2024
mkieweg pushed a commit to mkieweg/argo-cd that referenced this pull request Jun 11, 2024
…roj#17734)

Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
…roj#17734)

Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants