[DRAFT] Replace runtime.RawUnstructured with internal ArgoCD type to avoid #15126#17725
Closed
PaulSonOfLars wants to merge 27 commits intoargoproj:masterfrom
Closed
[DRAFT] Replace runtime.RawUnstructured with internal ArgoCD type to avoid #15126#17725PaulSonOfLars wants to merge 27 commits intoargoproj:masterfrom
PaulSonOfLars wants to merge 27 commits intoargoproj:masterfrom
Conversation
…j#15126) Signed-off-by: Vlad Fratila <vlad.fratila@gmail.com> Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
when applying a patch, the rawextenstion object used for valuesObject needs to be diffed with jsonpatch instead of the default strategic merge Signed-off-by: Vlad Fratila <vlad.fratila@gmail.com> Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Vlad Fratila <vlad.fratila@gmail.com> Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Vlad Fratila <vlad.fratila@gmail.com> Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
…ts for both app.Source and app.Sources fields Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
…-jsonpatching Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
…-jsonpatching Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
…-jsonpatching Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
…internal type Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
PaulSonOfLars
force-pushed
the
paul/remove-values-rawextension
branch
from
f509f1b to
b98f51f
Compare
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
PaulSonOfLars
force-pushed
the
paul/remove-values-rawextension
branch
from
a942d21 to
0d67d50
Compare
Contributor
Author
|
Closing at this test didn't work out as planned |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This is a draft PR to see if CI has better luck with building; having issues on my local env.
Checklist: