Skip to content

docs: added warning for multiple sources#17670

Merged
crenshaw-dev merged 2 commits intoargoproj:masterfrom
kostis-codefresh:docs-warning-multi-source
Mar 29, 2024
Merged

docs: added warning for multiple sources#17670
crenshaw-dev merged 2 commits intoargoproj:masterfrom
kostis-codefresh:docs-warning-multi-source

Conversation

@kostis-codefresh
Copy link
Member

@kostis-codefresh kostis-codefresh commented Mar 29, 2024 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@kostis-codefresh
docs: added warning for multiple sources
7d0dffa 
Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>
@kostis-codefresh kostis-codefresh requested review from a team as code owners March 29, 2024 11:18
@kostis-codefresh
docs: minor spelling
dd00b14 
Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>
pasha-codefresh
pasha-codefresh approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@pasha-codefresh pasha-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crenshaw-dev crenshaw-dev merged commit b711c5b into argoproj:master Mar 29, 2024
mkieweg pushed a commit to mkieweg/argo-cd that referenced this pull request Jun 11, 2024
@kostis-codefresh @mkieweg
docs: added warning for multiple sources (argoproj#17670)
c5c3494 
* docs: added warning for multiple sources

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>

* docs: minor spelling

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>

---------

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@kostis-codefresh @Hariharasuthan99
docs: added warning for multiple sources (argoproj#17670)
8b4243f 
* docs: added warning for multiple sources

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>

* docs: minor spelling

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>

---------

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>
@mrhwick
Copy link

mrhwick commented Jan 22, 2026

@kostis-codefresh Do you recall what situation, discussion, or issues caused you to add this warning?

@kostis-codefresh
Copy link
Member Author

kostis-codefresh commented Jan 22, 2026

Yes. Check the comic shown here in anti pattern 8 https://codefresh.io/blog/argo-cd-anti-patterns-for-gitops/

It is a real story with a real person. That was the most extreme example but I have talked with other people as well who think that multi source is a generic grouping mechanism

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

@pasha-codefresh pasha-codefresh pasha-codefresh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kostis-codefresh @mrhwick @crenshaw-dev @pasha-codefresh