chore: wrap error for SyncKeyRingFromDirectory#17633
Merged
ishitasequeira merged 1 commit intoargoproj:masterfrom Mar 27, 2024
Merged
chore: wrap error for SyncKeyRingFromDirectory#17633ishitasequeira merged 1 commit intoargoproj:masterfrom
ishitasequeira merged 1 commit intoargoproj:masterfrom
Conversation
Signed-off-by: danqixu <yzxudanqi@gmail.com>
ishitasequeira
approved these changes
Mar 27, 2024
Member
ishitasequeira
left a comment
ishitasequeira
left a comment
There was a problem hiding this comment.
Thanks @danqixu!! LGTM!!
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
Signed-off-by: danqixu <yzxudanqi@gmail.com> Signed-off-by: Kevin Lyda <kevin@lyda.ie>
mkieweg
pushed a commit
to mkieweg/argo-cd
that referenced
this pull request
Jun 11, 2024
Signed-off-by: danqixu <yzxudanqi@gmail.com>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
Signed-off-by: danqixu <yzxudanqi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to this issue #10592