Skip to content

docs: Update argocd-cm.yaml bannerposition description (#16961)#16962

Merged
ishitasequeira merged 1 commit intoargoproj:masterfrom
keithchong:16961-UpdateArgocdCm
Jan 23, 2024
Merged

docs: Update argocd-cm.yaml bannerposition description (#16961)#16962
ishitasequeira merged 1 commit intoargoproj:masterfrom
keithchong:16961-UpdateArgocdCm

Conversation

@keithchong
Copy link
Contributor

@keithchong keithchong commented Jan 23, 2024

Fixes #16961

The cool feature #14623 was added. We need to update the sample argocd-cm.yaml file in the documentation.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@keithchong keithchong requested review from a team as code owners January 23, 2024 17:40
@codecov
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (97727cb) 49.21% compared to head (898d907) 49.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #16962   +/-   ##
=======================================
  Coverage   49.21%   49.21%           
=======================================
  Files         274      274           
  Lines       48111    48111           
=======================================
  Hits        23677    23677           
  Misses      22090    22090           
  Partials     2344     2344           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keithchong keithchong changed the title fix: Update argocd-cm.yaml bannerposition description (#16961) docs: Update argocd-cm.yaml bannerposition description (#16961) Jan 23, 2024
Signed-off-by: Keith Chong <kykchong@redhat.com>
@keithchong keithchong force-pushed the 16961-UpdateArgocdCm branch from 8db9523 to 898d907 Compare January 23, 2024 19:14
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ishitasequeira ishitasequeira merged commit fec5708 into argoproj:master Jan 23, 2024
JulienFuix pushed a commit to JulienFuix/argo-cd that referenced this pull request Feb 6, 2024
clement-heetch pushed a commit to clement-heetch/argo-cd that referenced this pull request Feb 12, 2024
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Feb 25, 2024
… (argoproj#16962)

Signed-off-by: Keith Chong <kykchong@redhat.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
penglongli pushed a commit to penglongli/argo-cd that referenced this pull request Mar 6, 2024
… (argoproj#16962)

Signed-off-by: Keith Chong <kykchong@redhat.com>
Signed-off-by: penglongli <pelenli@tencent.com>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
… (argoproj#16962)

Signed-off-by: Keith Chong <kykchong@redhat.com>
Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update argocd-cm.yaml bannerposition description

2 participants