Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #1668 - Replicasets ordering is not stable on app tree view #1669

Merged
merged 1 commit into from
Jun 1, 2019
Merged

Issue #1668 - Replicasets ordering is not stable on app tree view #1669

merged 1 commit into from
Jun 1, 2019

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented May 31, 2019 •
edited
Loading

Closes #1668

@alexmt alexmt requested review from alexec and jessesuen May 31, 2019 22:39
@codecov
Copy link

codecov bot commented May 31, 2019 •
edited
Loading

Codecov Report

Merging #1669 into master will increase coverage by 0.08%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1669      +/-   ##
==========================================
+ Coverage   32.68%   32.76%   +0.08%     
==========================================
  Files          71       71              
  Lines       11321    11328       +7     
==========================================
+ Hits         3700     3712      +12     
+ Misses       7080     7070      -10     
- Partials      541      546       +5
Impacted Files Coverage Δ
controller/cache/cluster.go 60.88% <58.33%> (-0.79%) ⬇️
server/server.go 46.97% <0%> (+0.23%) ⬆️
controller/appcontroller.go 40.03% <0%> (+1.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a7c870...98e61ed. Read the comment docs.

alexec
alexec requested changes May 31, 2019
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests please

@alexmt alexmt force-pushed the 1668-child-order branch from 39ce23b to 98e61ed Compare May 31, 2019 23:46
@alexmt
Copy link
Collaborator Author

alexmt commented May 31, 2019

@alexec , added tests

@alexmt alexmt merged commit c214ed9 into argoproj:master Jun 1, 2019
@alexmt alexmt deleted the 1668-child-order branch July 15, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessesuen jessesuen jessesuen approved these changes

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replicasets ordering is not stable on app tree view
3 participants
@alexmt @alexec @jessesuen