fix(appset): Don't use revision cache when reconciling after webhook (#16062) (cherry-pick #16241)#16536
Merged
alexmt merged 1 commit intorelease-2.9from Dec 5, 2023
Merged
Conversation
…16062) (#16241) * fix(appset): store sha from webhook to get latest change during reconcile (#16062) Signed-off-by: dhruvang1 <dhruvang1@users.noreply.github.com> * fix(appset): Don't use revision cache when reconciling after webhook(#16062) Signed-off-by: dhruvang1 <dhruvang1@users.noreply.github.com> --------- Signed-off-by: dhruvang1 <dhruvang1@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-2.9 #16536 +/- ##
===============================================
- Coverage 50.02% 50.02% -0.01%
===============================================
Files 267 267
Lines 46191 46196 +5
===============================================
+ Hits 23109 23111 +2
- Misses 20816 20818 +2
- Partials 2266 2267 +1 ☔ View full report in Codecov by Sentry. |
alexmt
approved these changes
Dec 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix(appset): Don't use revision cache when reconciling after webhook (#16062) (#16241)
Signed-off-by: dhruvang1 dhruvang1@users.noreply.github.com
Signed-off-by: dhruvang1 dhruvang1@users.noreply.github.com
Signed-off-by: dhruvang1 dhruvang1@users.noreply.github.com