-
Notifications
You must be signed in to change notification settings - Fork 7k
docs: added all available fields for applicationset.yaml #16095 #16104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
crenshaw-dev
merged 8 commits into
argoproj:master
from
akagami-harsh:updating-applicationset.yaml
Mar 13, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ce036e7
adding all available filds for generators
akagami-harsh 185c8b0
add remaining fields in applicationset.yml
akagami-harsh 6dfa57b
Update docs/operator-manual/applicationset.yaml
akagami-harsh 4366bba
Update docs/operator-manual/applicationset.yaml
akagami-harsh 031624a
Update docs/operator-manual/applicationset.yaml
akagami-harsh 7d93c92
Update docs/operator-manual/applicationset.yaml
akagami-harsh 40af7cf
fix
akagami-harsh ea12fa5
Merge branch 'master' into updating-applicationset.yaml
crenshaw-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk how this has changed, but preservedFields is currently under spec, not metadata, and it takes a list of strings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Can you open a PR to fix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#20206