Skip to content

fix(action): populate all fields of Job from CronJob (#15259) (cherry-pick #15727) #15730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crenshaw-dev merged 1 commit into from
Sep 29, 2023
+3 −5
Merged

fix(action): populate all fields of Job from CronJob (#15259) (cherry-pick #15727) #15730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions resource_customizations/batch/CronJob/actions/create-job/action.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,7 @@ ownerRef.uid = obj.metadata.uid
job.metadata.ownerReferences = {}
job.metadata.ownerReferences[1] = ownerRef

job.spec = {}
job.spec.suspend = false
job.spec.template = {}
job.spec.template.metadata = deepCopy(obj.spec.jobTemplate.spec.template.metadata)
job.spec.template.spec = deepCopy(obj.spec.jobTemplate.spec.template.spec)
job.spec = deepCopy(obj.spec.jobTemplate.spec)

local impactedResource = {}
impactedResource.operation = "create"
Expand Down
1 change: 1 addition & 0 deletions resource_customizations/batch/CronJob/actions/testdata/cronjob.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ spec:
annotations:
my: annotation
spec:
ttlSecondsAfterFinished: 100
template:
metadata:
labels:
Expand Down
1 change: 1 addition & 0 deletions resource_customizations/batch/CronJob/actions/testdata/job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
annotations:
my: annotation
spec:
ttlSecondsAfterFinished: 100
template:
metadata:
labels:
Expand Down