Skip to content

fix: "Create Job" action doesn't act like kubectl create job --from=<CRON_JOB_NAME> command #15259#15671

Closed
kodzimo wants to merge 6 commits intoargoproj:masterfrom
kodzimo:createjob-action-fix
Closed

fix: "Create Job" action doesn't act like kubectl create job --from=<CRON_JOB_NAME> command #15259#15671
kodzimo wants to merge 6 commits intoargoproj:masterfrom
kodzimo:createjob-action-fix

Conversation

@kodzimo
Copy link

@kodzimo kodzimo commented Sep 26, 2023

Checklist:

  • This is a bug fix.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them. - doesn't need to be updated.
  • Does this PR require documentation updates? - No.
  • I've updated documentation as required by this PR. - No docs to update.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Closes [ISSUE #15259]" and "Fixes [ISSUE #15259]

When we trigger action "Create Job" it is expected to perform as kubectl create job --from=<CRON_JOB_NAME> command. This PR fixes the issue mentioned above.

@kodzimo kodzimo requested a review from a team as a code owner September 26, 2023 11:39
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (fd655e9) 49.98% compared to head (04bdf48) 49.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #15671   +/-   ##
=======================================
  Coverage   49.98%   49.99%           
=======================================
  Files         266      266           
  Lines       46039    46039           
=======================================
+ Hits        23012    23015    +3     
+ Misses      20771    20767    -4     
- Partials     2256     2257    +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodzimo kodzimo force-pushed the createjob-action-fix branch 6 times, most recently from 18b57fb to ce2e2c9 Compare September 27, 2023 05:56
Dzmitry Pukhau added 6 commits September 29, 2023 17:18
Signed-off-by: Dzmitry Pukhau <dmitriy.pukhov@vizor-games.com>
Signed-off-by: Dzmitry Pukhau <dmitriy.pukhov@vizor-games.com>
Signed-off-by: Dzmitry Pukhau <dmitriy.pukhov@vizor-games.com>
Signed-off-by: Dzmitry Pukhau <dmitriy.pukhov@vizor-games.com>
Signed-off-by: Dzmitry Pukhau <dmitriy.pukhov@vizor-games.com>
Signed-off-by: Dzmitry Pukhau <dmitriy.pukhov@vizor-games.com>
@kodzimo kodzimo force-pushed the createjob-action-fix branch from a853d08 to 04bdf48 Compare September 29, 2023 14:18
@kodzimo
Copy link
Author

kodzimo commented Sep 29, 2023

irrelevant due to this PR

@kodzimo kodzimo closed this Sep 29, 2023
@kodzimo kodzimo deleted the createjob-action-fix branch September 29, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant