feat(server): Add maxPodLogsToRender setting (#9131)

[lukaszgyg]

This PR is adding the configurable maxPodLogsToRender . This will allow the Argo-CD administrators to allow higher number of pods logs to be rendered in UI and avoid the rpc error: code = Unknown desc = Max pods to view logs are reached. Please provide more granular query. error as described in the issue #9131.
Closes ISSUE #9131

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

[codecov]

Codecov Report

Attention: Patch coverage is 14.28571% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 49.40%. Comparing base (05eea87) to head (3a8d1df).
Report is 48 commits behind head on master.

❗ Current head 3a8d1df differs from pull request most recent head 918b25c. Consider uploading reports for the commit 918b25c to get more accurate results

Files	Patch %	Lines
util/settings/settings.go	0.00%	14 Missing and 1 partial ⚠️
server/application/application.go	50.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #14617      +/-   ##
==========================================
- Coverage   49.44%   49.40%   -0.05%     
==========================================
  Files         273      272       -1     
  Lines       48662    47994     -668     
==========================================
- Hits        24063    23713     -350     
+ Misses      22237    21930     -307     
+ Partials     2362     2351      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[alexef]

this is the root error that ends up in the argocd throwing 500 error responses.

while I agree having a configurable limit may mitigate this to some extent, can we also solve the generic case and treat this error differently?

a 4xx response may be more fitted.

[lukaszgyg]

As specifying the log query will fix the problem I took the codes.InvalidArgument which will be transformed to http.StatusBadRequest

[Jellyfrog]

Maybe the variable should be removed here also?

argo-cd/server/application/application.go

Line 68 in b12630c

maxPodLogsToRender = 10

[lukaszgyg]

Thanks @Jellyfrog for a good catch! I removed unused const.

[lukaszgyg]

@leoluz I updated my PR base on your suggestion from the ArgoCD contributor meeting. Can you take a look?

[Naist4869]

Is there any progress? This will be my motivation to upgrade the ArgoCD version.

[lukaszgyg]

Is there any progress? This will be my motivation to upgrade the ArgoCD version.

The implementation is done. I'm waiting for review.
@crenshaw-dev can you have a look?

[ishitasequeira]

LGTM!!

stale