docs(deep-links): Fix link to pkg.go.dev to not return 404#14595
Merged
crenshaw-dev merged 1 commit intoargoproj:masterfrom Jul 21, 2023
Merged
docs(deep-links): Fix link to pkg.go.dev to not return 404#14595crenshaw-dev merged 1 commit intoargoproj:masterfrom
crenshaw-dev merged 1 commit intoargoproj:masterfrom
Conversation
Signed-off-by: Håkon Solbjørg <hakon@solbj.org>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #14595 +/- ##
=======================================
Coverage 49.81% 49.82%
=======================================
Files 261 261
Lines 44796 44796
=======================================
+ Hits 22317 22320 +3
+ Misses 20280 20278 -2
+ Partials 2199 2198 -1 ☔ View full report in Codecov by Sentry. |
ishitasequeira
approved these changes
Jul 20, 2023
Member
ishitasequeira
left a comment
ishitasequeira
left a comment
There was a problem hiding this comment.
Thanks for the PR @sklirg !! LGTM!!
Contributor
Author
|
Anything else you need from me, @ishitasequeira ? :) |
Member
|
/cherry-pick release-2.8 |
Member
|
/cherry-pick release-2.7 |
Member
|
/cherry-pick release-2.6 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
Signed-off-by: Håkon Solbjørg <hakon@solbj.org>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
Signed-off-by: Håkon Solbjørg <hakon@solbj.org>
|
Cherry-pick failed with |
crenshaw-dev
pushed a commit
that referenced
this pull request
Jul 21, 2023
crenshaw-dev
pushed a commit
that referenced
this pull request
Jul 21, 2023
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Jul 24, 2023
…14595) (argoproj#14640) Signed-off-by: Håkon Solbjørg <hakon@solbj.org> Co-authored-by: Håkon Solbjørg <hakon@solbj.org> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…14595) Signed-off-by: Håkon Solbjørg <hakon@solbj.org>
Closed
Jneville0815
pushed a commit
to radiusmethod/argo-cd
that referenced
this pull request
Sep 30, 2023
…14595) Signed-off-by: Håkon Solbjørg <hakon@solbj.org> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…14595) Signed-off-by: Håkon Solbjørg <hakon@solbj.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, the link returns a 404 because it is redirected to
https://argo-cd.readthedocs.io/en/stable/operator-manual/deep_links/pkg.go.dev/text/template.Steps to reproduce:
https://argo-cd.readthedocs.io/en/stable/operator-manual/deep_links/pkg.go.dev/text/templatewhich is a 404 (if you scroll all the way down).Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
[ ] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.[ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.[ ] Does this PR require documentation updates?[ ] Optional. My organization is added to USERS.md.[ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.[ ] My new feature complies with the feature status guidelines.Please see Contribution FAQs if you have questions about your pull-request.