fix(appset): normalize app spec before applying (cherry-pick #14481)#14555
Merged
crenshaw-dev merged 1 commit intorelease-2.7from Jul 17, 2023
Merged
fix(appset): normalize app spec before applying (cherry-pick #14481)#14555crenshaw-dev merged 1 commit intorelease-2.7from
crenshaw-dev merged 1 commit intorelease-2.7from
Conversation
* fix(appset): normalize app spec before applying Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix nil ref, add test Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix another test Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
approved these changes
Jul 17, 2023
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Jul 24, 2023
…oproj#14555) * fix(appset): normalize app spec before applying * fix nil ref, add test * fix another test --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix(appset): normalize app spec before applying (#14481)
Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com