fix(ui): Correct pod log viewer to support short log lines (#14402)#14543
Merged
crenshaw-dev merged 1 commit intoargoproj:masterfrom Jul 18, 2023
Merged
fix(ui): Correct pod log viewer to support short log lines (#14402)#14543crenshaw-dev merged 1 commit intoargoproj:masterfrom
crenshaw-dev merged 1 commit intoargoproj:masterfrom
Conversation
…j#14402 Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Member
|
@terrytangyuan how far back do we need to cherry-pick this? 2.7 I think? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #14543 +/- ##
==========================================
- Coverage 49.79% 49.79% -0.01%
==========================================
Files 261 261
Lines 44751 44755 +4
==========================================
+ Hits 22283 22284 +1
- Misses 20274 20276 +2
- Partials 2194 2195 +1
☔ View full report in Codecov by Sentry. |
Member
Author
|
v2.7 seems reasonable (I am using v2.7.6). Could you also help test the change locally to make sure nothing else breaks? |
terrytangyuan
changed the title
crenshaw-dev
changed the title
Member
|
/cherry-pick release-2.8 |
Member
|
/cherry-pick release-2.7 |
rbreeze
approved these changes
Jul 17, 2023
Member
|
@rbreeze have you had a chance to test locally? If so, I'll smash merge. |
Member
Author
|
Let me perform more testing before merging this since this will be cherry-picked. |
Member
|
I was about to test, but |
Member
Author
|
@crenshaw-dev Verified that this looks good locally. |
crenshaw-dev
pushed a commit
that referenced
this pull request
Jul 18, 2023
crenshaw-dev
pushed a commit
that referenced
this pull request
Jul 18, 2023
Jneville0815
pushed a commit
to radiusmethod/argo-cd
that referenced
this pull request
Jul 18, 2023
…j#14402 (argoproj#14543) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Jul 24, 2023
…j#14402 (argoproj#14543) (argoproj#14562) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Co-authored-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…j#14402 (argoproj#14543) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Closed
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…j#14402 (argoproj#14543) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14402