chore: use t.Setenv to set env vars in tests#14377
Merged
crenshaw-dev merged 1 commit intoargoproj:masterfrom Jul 6, 2023
Juneezee:test/t.Setenv
Merged
chore: use t.Setenv to set env vars in tests#14377crenshaw-dev merged 1 commit intoargoproj:masterfrom Juneezee:test/t.Setenv
t.Setenv to set env vars in tests#14377crenshaw-dev merged 1 commit intoargoproj:masterfrom
Juneezee:test/t.Setenv
Conversation
This commit replaces `os.Setenv` with `t.Setenv` in tests. The environment variable is automatically restored to its original value when the test and all its subtests complete. Reference: https://pkg.go.dev/testing#T.Setenv Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #14377 +/- ##
=======================================
Coverage 49.74% 49.75%
=======================================
Files 261 261
Lines 44676 44676
=======================================
+ Hits 22225 22229 +4
+ Misses 20262 20259 -3
+ Partials 2189 2188 -1 ☔ View full report in Codecov by Sentry. |
Member
blakepettersson
left a comment
There was a problem hiding this comment.
One minor nit, otherwise LGTM! 🍾
blakepettersson
approved these changes
Jul 6, 2023
crenshaw-dev
approved these changes
Jul 6, 2023
Member
crenshaw-dev
left a comment
There was a problem hiding this comment.
Lovely. Thank you, @Juneezee!
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
This commit replaces `os.Setenv` with `t.Setenv` in tests. The environment variable is automatically restored to its original value when the test and all its subtests complete. Reference: https://pkg.go.dev/testing#T.Setenv Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Closed
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
This commit replaces `os.Setenv` with `t.Setenv` in tests. The environment variable is automatically restored to its original value when the test and all its subtests complete. Reference: https://pkg.go.dev/testing#T.Setenv Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from Go 1.17, we can use
t.Setenvto set environment variable in test. The environment variable is automatically restored to its original value when the test and all its subtests complete. This ensures that each test does not start with leftover environment variables from previous completed tests.Reference: https://pkg.go.dev/testing#T.Setenv
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.