docs: managedFieldsManagers example in docs needs double-quotes#14324
Merged
crenshaw-dev merged 1 commit intoargoproj:masterfrom Jul 6, 2023
Merged
docs: managedFieldsManagers example in docs needs double-quotes#14324crenshaw-dev merged 1 commit intoargoproj:masterfrom
crenshaw-dev merged 1 commit intoargoproj:masterfrom
Conversation
* is a Yaml special character and must be quoted, otherwise ArgoCD fails to parse and shows an error. Signed-off-by: Paul Martin <paul.martin@gmail.com>
pgpx
changed the title
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #14324 +/- ##
=======================================
Coverage 49.76% 49.76%
=======================================
Files 261 261
Lines 44676 44676
=======================================
Hits 22232 22232
Misses 20257 20257
Partials 2187 2187 ☔ View full report in Codecov by Sentry. |
ishitasequeira
approved these changes
Jul 6, 2023
Member
ishitasequeira
left a comment
ishitasequeira
left a comment
There was a problem hiding this comment.
Thanks @pgpx , Looks good!!
blakepettersson
added
the
ready-for-review
crenshaw-dev
approved these changes
Jul 6, 2023
Member
crenshaw-dev
left a comment
crenshaw-dev
left a comment
There was a problem hiding this comment.
Great catch, thank you @pgpx!
crenshaw-dev
changed the title
Member
|
/cherry-pick release-2.8 |
Member
|
/cherry-pick release-2.7 |
Member
|
/cherry-pick release-2.6 |
Member
|
/cherry-pick release-2.5 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 6, 2023
* is a Yaml special character and must be quoted, otherwise ArgoCD fails to parse and shows an error. Signed-off-by: Paul Martin <paul.martin@gmail.com>
This was referenced Jul 6, 2023
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 6, 2023
* is a Yaml special character and must be quoted, otherwise ArgoCD fails to parse and shows an error. Signed-off-by: Paul Martin <paul.martin@gmail.com>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 6, 2023
* is a Yaml special character and must be quoted, otherwise ArgoCD fails to parse and shows an error. Signed-off-by: Paul Martin <paul.martin@gmail.com>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 6, 2023
* is a Yaml special character and must be quoted, otherwise ArgoCD fails to parse and shows an error. Signed-off-by: Paul Martin <paul.martin@gmail.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Jul 6, 2023
…) (#14371) * is a Yaml special character and must be quoted, otherwise ArgoCD fails to parse and shows an error. Signed-off-by: Paul Martin <paul.martin@gmail.com> Co-authored-by: Paul Martin <paul.martin@gmail.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Jul 6, 2023
…) (#14372) * is a Yaml special character and must be quoted, otherwise ArgoCD fails to parse and shows an error. Signed-off-by: Paul Martin <paul.martin@gmail.com> Co-authored-by: Paul Martin <paul.martin@gmail.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Jul 6, 2023
…) (#14374) * is a Yaml special character and must be quoted, otherwise ArgoCD fails to parse and shows an error. Signed-off-by: Paul Martin <paul.martin@gmail.com> Co-authored-by: Paul Martin <paul.martin@gmail.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Jul 6, 2023
…) (#14373) * is a Yaml special character and must be quoted, otherwise ArgoCD fails to parse and shows an error. Signed-off-by: Paul Martin <paul.martin@gmail.com> Co-authored-by: Paul Martin <paul.martin@gmail.com>
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Jul 24, 2023
…proj#14324) (argoproj#14372) * is a Yaml special character and must be quoted, otherwise ArgoCD fails to parse and shows an error. Signed-off-by: Paul Martin <paul.martin@gmail.com> Co-authored-by: Paul Martin <paul.martin@gmail.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…proj#14324) * is a Yaml special character and must be quoted, otherwise ArgoCD fails to parse and shows an error. Signed-off-by: Paul Martin <paul.martin@gmail.com>
Closed
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…proj#14324) * is a Yaml special character and must be quoted, otherwise ArgoCD fails to parse and shows an error. Signed-off-by: Paul Martin <paul.martin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14323
On https://argo-cd.readthedocs.io/en/stable/user-guide/diffing/#application-level-configuration the managedFieldsManagers example should have double-quoted the
*wildcards (e.g."*") because*is a YAML special character, and without this the examples cannot be parsed by ArgoCD (raising an error).