docs: change to the correct property for the dex server value#14279
Merged
crenshaw-dev merged 2 commits intoargoproj:masterfrom Jun 30, 2023
bjarneo:patch-1
Merged
docs: change to the correct property for the dex server value#14279crenshaw-dev merged 2 commits intoargoproj:masterfrom bjarneo:patch-1
crenshaw-dev merged 2 commits intoargoproj:masterfrom
bjarneo:patch-1
Conversation
Signed-off-by: bjarneo <bjarneo@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
changed the title
Member
|
/cherry-pick release-2.8 |
Member
|
/cherry-pick release-2.7 |
Member
|
/cherry-pick release-2.6 |
Member
|
/cherry-pick release-2.5 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jun 30, 2023
* fix: change to the correct property for dex server Signed-off-by: bjarneo <bjarneo@users.noreply.github.com> * Update argocd-cmd-params-cm.yaml Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: bjarneo <bjarneo@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
|
Cherry-pick failed with |
|
Cherry-pick failed with |
|
Cherry-pick failed with |
crenshaw-dev
added a commit
that referenced
this pull request
Jun 30, 2023
#14291) * fix: change to the correct property for dex server * Update argocd-cmd-params-cm.yaml --------- Signed-off-by: bjarneo <bjarneo@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: bjarneo <bjarneo@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…oj#14279) * fix: change to the correct property for dex server Signed-off-by: bjarneo <bjarneo@users.noreply.github.com> * Update argocd-cmd-params-cm.yaml Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: bjarneo <bjarneo@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Closed
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…oj#14279) * fix: change to the correct property for dex server Signed-off-by: bjarneo <bjarneo@users.noreply.github.com> * Update argocd-cmd-params-cm.yaml Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: bjarneo <bjarneo@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative approach is to update the config map to fetch from dex.server: https://github.com/argoproj/argo-cd/blob/master/manifests/base/server/argocd-server-deployment.yaml#L62-L67
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.