fix(ui): Added rel="noopener noreferrer" to link (#13820)#14268
Merged
crenshaw-dev merged 2 commits intoargoproj:masterfrom Jun 30, 2023
Merged
fix(ui): Added rel="noopener noreferrer" to link (#13820)#14268crenshaw-dev merged 2 commits intoargoproj:masterfrom
crenshaw-dev merged 2 commits intoargoproj:masterfrom
Conversation
Signed-off-by: aakankshabhende <aakanksha0407@gmail.com>
Signed-off-by: aakankshabhende <aakanksha0407@gmail.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #14268 +/- ##
=======================================
Coverage 49.76% 49.77%
=======================================
Files 261 261
Lines 44667 44667
=======================================
+ Hits 22230 22233 +3
+ Misses 20251 20249 -2
+ Partials 2186 2185 -1 ☔ View full report in Codecov by Sentry. |
crenshaw-dev
approved these changes
Jun 30, 2023
Member
crenshaw-dev
left a comment
There was a problem hiding this comment.
Just to note: I don't think this actually resolves a security issue. fullscreenURL will be on the same domain as Argo CD. But it is nice to quiet down false positives from scanners.
Thanks for the PR, @aakankshabhende!
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…goproj#14268) * Added rel attribute to link Signed-off-by: aakankshabhende <aakanksha0407@gmail.com> * Fixed lint error Signed-off-by: aakankshabhende <aakanksha0407@gmail.com> --------- Signed-off-by: aakankshabhende <aakanksha0407@gmail.com>
Closed
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…goproj#14268) * Added rel attribute to link Signed-off-by: aakankshabhende <aakanksha0407@gmail.com> * Fixed lint error Signed-off-by: aakankshabhende <aakanksha0407@gmail.com> --------- Signed-off-by: aakankshabhende <aakanksha0407@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13820
Added rel="noopener noreferrer" attribute to link for security.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.