Skip to content

fix(action): copy metadata on create-job action (#14232) #14233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pasha-codefresh merged 1 commit into from
Jul 11, 2023
Merged

fix(action): copy metadata on create-job action (#14232) #14233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion resource_customizations/batch/CronJob/actions/create-job/action.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,10 @@ job = {}
job.apiVersion = "batch/v1"
job.kind = "Job"

job.metadata = {}
job.metadata = deepCopy(obj.spec.jobTemplate.metadata)
if job.metadata == nil then
job.metadata = {}
end
job.metadata.name = obj.metadata.name .. "-" ..os.date("!%Y%m%d%H%M")
job.metadata.namespace = obj.metadata.namespace

Expand All @@ -47,6 +50,7 @@ job.metadata.ownerReferences[1] = ownerRef
job.spec = {}
job.spec.suspend = false
job.spec.template = {}
job.spec.template.metadata = deepCopy(obj.spec.jobTemplate.spec.template.metadata)
job.spec.template.spec = deepCopy(obj.spec.jobTemplate.spec.template.spec)

impactedResource = {}
Expand Down
10 changes: 10 additions & 0 deletions resource_customizations/batch/CronJob/actions/testdata/cronjob.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,18 @@ metadata:
spec:
schedule: "* * * * *"
jobTemplate:
metadata:
labels:
my: label
annotations:
my: annotation
spec:
template:
metadata:
labels:
pod: label
annotations:
pod: annotation
spec:
containers:
- name: hello
Expand Down
9 changes: 9 additions & 0 deletions resource_customizations/batch/CronJob/actions/testdata/job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,17 @@
metadata:
name: hello-00000000000
namespace: test-ns
labels:
my: label
annotations:
my: annotation
spec:
template:
metadata:
labels:
pod: label
annotations:
pod: annotation
spec:
containers:
- name: hello
Expand Down