fix: Fix pod log viewer scrollbars#14199
Merged
crenshaw-dev merged 5 commits intoargoproj:masterfrom Jul 9, 2023
Merged
Conversation
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
todaywasawesome
added
the
ready-for-review
Contributor
Author
|
@crenshaw-dev can I bump review pls? |
crenshaw-dev
approved these changes
Jul 7, 2023
Member
crenshaw-dev
left a comment
crenshaw-dev
left a comment
There was a problem hiding this comment.
Local test confirms scrolls are scrollier.
Member
|
@alexec can you check the CI lint issue? |
Member
|
/cherry-pick release-2.8 |
Member
|
/cherry-pick release-2.7 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #14199 +/- ##
==========================================
- Coverage 49.73% 49.72% -0.01%
==========================================
Files 261 261
Lines 44705 44705
==========================================
- Hits 22234 22231 -3
- Misses 20284 20286 +2
- Partials 2187 2188 +1 ☔ View full report in Codecov by Sentry. |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 9, 2023
* fix: Fix pod log viewer scrollbars Signed-off-by: Alex Collins <alex_collins@intuit.com> * fix scrolling Signed-off-by: Alex Collins <alex_collins@intuit.com> --------- Signed-off-by: Alex Collins <alex_collins@intuit.com>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 9, 2023
* fix: Fix pod log viewer scrollbars Signed-off-by: Alex Collins <alex_collins@intuit.com> * fix scrolling Signed-off-by: Alex Collins <alex_collins@intuit.com> --------- Signed-off-by: Alex Collins <alex_collins@intuit.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Jul 11, 2023
crenshaw-dev
pushed a commit
that referenced
this pull request
Jul 11, 2023
3 tasks
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Jul 24, 2023
* fix: Fix pod log viewer scrollbars * fix scrolling --------- Signed-off-by: Alex Collins <alex_collins@intuit.com> Co-authored-by: Alex Collins <alexec@users.noreply.github.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
* fix: Fix pod log viewer scrollbars Signed-off-by: Alex Collins <alex_collins@intuit.com> * fix scrolling Signed-off-by: Alex Collins <alex_collins@intuit.com> --------- Signed-off-by: Alex Collins <alex_collins@intuit.com>
Closed
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
* fix: Fix pod log viewer scrollbars Signed-off-by: Alex Collins <alex_collins@intuit.com> * fix scrolling Signed-off-by: Alex Collins <alex_collins@intuit.com> --------- Signed-off-by: Alex Collins <alex_collins@intuit.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List. You must useGrid.scrollToBottomwhen the user tries to scroll to the bottom.