chore: adding test coverage PodLogs & NewApplicationLogsTestCommand#14045
Closed
zhaque44 wants to merge 3 commits intoargoproj:masterfrom
Closed
chore: adding test coverage PodLogs & NewApplicationLogsTestCommand#14045zhaque44 wants to merge 3 commits intoargoproj:masterfrom
zhaque44 wants to merge 3 commits intoargoproj:masterfrom
Conversation
…3398 Signed-off-by: zhaque44 <haque.zubair@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #14045 +/- ##
==========================================
+ Coverage 49.57% 49.69% +0.12%
==========================================
Files 256 256
Lines 43920 43941 +21
==========================================
+ Hits 21773 21837 +64
+ Misses 19985 19940 -45
- Partials 2162 2164 +2
☔ View full report in Codecov by Sentry. |
Contributor
Author
|
closing this PR due to the fact that we have most likely uncovered the underlying issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This effort is to help fix the ArgoCD build pipelines and help remove flaky tests:
Ticket: #13398
Adding tests for the
PodLogsfunc:TestPodLogs:This test verifies that thePodLogsfunction retrieves logs for a specific pod without any errors. It sets up the mocks, calls the function, and asserts that the returned logs match the expected logs.TestPodLogs_RBAC:This test validates that thePodLogsfunction successfully retrieves logs for a specific pod, taking into account RBAC enforcement. It sets up mocks with RBAC policies, calls the function, and asserts that the returned logs.TestPodLogs_Cancellation:This test verifies that thePodLogsfunction successfully retrieves logs for a specific pod and ensures that the logs are received without any errors.TestPodLogs_CancellationError:This test validates that thePodLogsfunction handles the scenario where there is an error while retrieving the logs.Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.