Skip to content

fix: k8s upgrade e2e tests#13984

Closed
crenshaw-dev wants to merge 4 commits intoargoproj:masterfrom
crenshaw-dev:k8s-server-side-stuff
Closed

fix: k8s upgrade e2e tests#13984
crenshaw-dev wants to merge 4 commits intoargoproj:masterfrom
crenshaw-dev:k8s-server-side-stuff

Conversation

@crenshaw-dev
Copy link
Member

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

fengshunli and others added 2 commits June 9, 2023 10:43
Signed-off-by: fengshunli <1171313930@qq.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Patch coverage: 47.56% and no project coverage change.

Comparison is base (d3ec7f8) 49.56% compared to head (364ace2) 49.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #13984   +/-   ##
=======================================
  Coverage   49.56%   49.57%           
=======================================
  Files         256      256           
  Lines       43920    43961   +41     
=======================================
+ Hits        21770    21792   +22     
- Misses      19987    19996    +9     
- Partials     2163     2173   +10     
Impacted Files Coverage Δ
applicationset/utils/clusterUtils.go 68.33% <0.00%> (ø)
cmd/argocd/commands/admin/cluster.go 0.00% <0.00%> (ø)
cmd/util/project.go 12.14% <0.00%> (ø)
server/application/terminal.go 12.67% <0.00%> (ø)
util/db/cluster.go 59.49% <0.00%> (ø)
util/db/helmrepository.go 0.00% <0.00%> (ø)
util/db/secrets.go 79.04% <25.00%> (-2.51%) ⬇️
util/rbac/rbac.go 78.77% <25.00%> (-0.77%) ⬇️
util/settings/settings.go 49.50% <25.00%> (-0.50%) ⬇️
cmd/argocd/commands/app.go 21.80% <33.33%> (ø)
... and 5 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev marked this pull request as ready for review June 11, 2023 18:07
@crenshaw-dev crenshaw-dev marked this pull request as draft June 11, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants