fix: add gofmt to golangci-lint in Makefile and .github/workflows/ci-build.yaml#13729
fix: add gofmt to golangci-lint in Makefile and .github/workflows/ci-build.yaml#13729crenshaw-dev merged 3 commits intoargoproj:masterfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #13729 +/- ##
=======================================
Coverage 49.76% 49.76%
=======================================
Files 261 261
Lines 44676 44676
=======================================
Hits 22232 22232
Misses 20257 20257
Partials 2187 2187
☔ View full report in Codecov by Sentry. |
186c00a to
0f2c72e
Compare
526b7e0 to
40488aa
Compare
|
I'm gonna save this until after we cut 2.8-rc1. Wanna avoid anything that will reduce PR velocity until then. |
No worries. Let me know when you do it and I'll rebase just before that. |
|
@crenshaw-dev I have manually rebased this in case you want to merge it since v2.8.0-rc1 has been released. |
…build.yaml Signed-off-by: Denis Dupeyron <denis.dupeyron@gmail.com>
Signed-off-by: Denis Dupeyron <denis.dupeyron@gmail.com>
Signed-off-by: Denis Dupeyron <denis.dupeyron@gmail.com>
…i-build.yaml (argoproj#13729) * fix: add gofmt to golangci-lint in Makefile and .github/workflows/ci-build.yaml Signed-off-by: Denis Dupeyron <denis.dupeyron@gmail.com> * fix go formatting issues using gofmt Signed-off-by: Denis Dupeyron <denis.dupeyron@gmail.com> * chore: simplify go code using gofmt Signed-off-by: Denis Dupeyron <denis.dupeyron@gmail.com> --------- Signed-off-by: Denis Dupeyron <denis.dupeyron@gmail.com>
…i-build.yaml (argoproj#13729) * fix: add gofmt to golangci-lint in Makefile and .github/workflows/ci-build.yaml Signed-off-by: Denis Dupeyron <denis.dupeyron@gmail.com> * fix go formatting issues using gofmt Signed-off-by: Denis Dupeyron <denis.dupeyron@gmail.com> * chore: simplify go code using gofmt Signed-off-by: Denis Dupeyron <denis.dupeyron@gmail.com> --------- Signed-off-by: Denis Dupeyron <denis.dupeyron@gmail.com>
Out of curiosity I ran
gofmtat the top of the repo and it found quite a few formatting issues and simplifications. This PR addsgofmttogolangci-lintinMakefileand.github/workflows/ci-build.yamlto automatically detect/fix these issues in the future. It also applies the relevant changes provided by runninggofmt.Checklist: