Skip to content

feat: Added CopyFile from PR 12508#12751

Closed
gczuczy wants to merge 5 commits intoargoproj:masterfrom
gczuczy:copyfile-func
Closed

feat: Added CopyFile from PR 12508#12751
gczuczy wants to merge 5 commits intoargoproj:masterfrom
gczuczy:copyfile-func

Conversation

@gczuczy
Copy link
Contributor

@gczuczy gczuczy commented Mar 7, 2023

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Gergely Czuczy <gergely.czuczy@sap.com>
@gczuczy
Copy link
Contributor Author

gczuczy commented Mar 7, 2023

Note to self: Adjust #12508 once this get merged

@gczuczy
Copy link
Contributor Author

gczuczy commented Mar 7, 2023

FYI @crenshaw-dev

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 47.79%. Comparing base (5bdd42c) to head (e52246e).
Report is 1497 commits behind head on master.

Current head e52246e differs from pull request most recent head f03b4b4

Please upload reports for the commit f03b4b4 to get more accurate results.

Files Patch % Lines
util/argo/argo.go 70.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12751      +/-   ##
==========================================
+ Coverage   47.78%   47.79%   +0.01%     
==========================================
  Files         246      246              
  Lines       42019    42039      +20     
==========================================
+ Hits        20078    20092      +14     
- Misses      19939    19943       +4     
- Partials     2002     2004       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agaudreault agaudreault added the lifecycle/rotten Issue/PR had no activity for a long time and should be closed soon label May 31, 2024
Copy link
Member

@agaudreault agaudreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gczuczy, it seems like this PR was related to previous efforts that were abandoned.
I don't see anywhere in this PR where CopyFile is used. If this is a partial PR, please add the code that will use the CopyFile function, and a description/issue explaining the change.

Feel free to close the PR if it is not necessary anymore.

@gczuczy
Copy link
Contributor Author

gczuczy commented Jun 2, 2024

Hi @gczuczy, it seems like this PR was related to previous efforts that were abandoned. I don't see anywhere in this PR where CopyFile is used. If this is a partial PR, please add the code that will use the CopyFile function, and a description/issue explaining the change.

Fell free to close the PR if it is not necessary anymore.

@crenshaw-dev asked me to do this as part of PR12508. Can be scraped I think.

@gczuczy gczuczy closed this Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lifecycle/rotten Issue/PR had no activity for a long time and should be closed soon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants