fix: use non distroless image for dex#11219
Merged
crenshaw-dev merged 2 commits intoargoproj:masterfrom Nov 9, 2022
Merged
Conversation
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
Codecov ReportBase: 45.60% // Head: 45.60% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #11219 +/- ##
=======================================
Coverage 45.60% 45.60%
=======================================
Files 239 239
Lines 28973 28973
=======================================
Hits 13214 13214
Misses 13940 13940
Partials 1819 1819
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
crenshaw-dev
approved these changes
Nov 7, 2022
Member
crenshaw-dev
left a comment
crenshaw-dev
left a comment
There was a problem hiding this comment.
lgtm. Thanks to you both!
crenshaw-dev
added
cherry-pick/2.5
This was referenced Nov 7, 2022
crenshaw-dev
pushed a commit
that referenced
this pull request
Nov 9, 2022
* fix: use non distroless image for dex Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * change image in ci workflow Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Nov 9, 2022
* fix: use non distroless image for dex Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * change image in ci workflow Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Nov 9, 2022
* fix: use non distroless image for dex Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * change image in ci workflow Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
Member
|
Cherry-picked onto release-2.3 for 2.3.12, release-2.4 for 2.4.18, and release-2.5 for 2.5.3. |
3 tasks
ashutosh16
pushed a commit
to ashutosh16/argo-cd
that referenced
this pull request
Nov 23, 2022
* fix: use non distroless image for dex Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * change image in ci workflow Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
emirot
pushed a commit
to emirot/argo-cd
that referenced
this pull request
Jan 27, 2023
* fix: use non distroless image for dex Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * change image in ci workflow Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: emirot <emirot.nolan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Justin Marquis 34fathombelow@protonmail.com
Closes #11182
Closes #11105
Closes #11071
This PR reverts using a distroless image for Dex. There are permission errors between ArgoCD-dex & Dex binaries.
Two workarounds were tested successfully
or
First class stability and compatability should be provided. Rather than using a workaround that may be incompatible with certain cluster types.
Big thanks to @pdrastil for testing and verifying the workarounds and fix.