docs: proposal to merge image-updater into argo-cd

[jaideepr97]

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f3fc68) 45.69% compared to head (3aba27e) 45.69%.
Report is 1710 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #10447   +/-   ##
=======================================
  Coverage   45.69%   45.69%           
=======================================
  Files         234      234           
  Lines       28508    28508           
=======================================
  Hits        13027    13027           
  Misses      13694    13694           
  Partials     1787     1787           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jaideepr97]

@alexmt @leoluz
I updated this with the discussion points from the community meeting when I proposed it
could we merge this?

[leoluz]

@jaideepr97 Please avoid force-pushing once the PR is out as now I can't see what was added in the proposal since our last conversation.
Can you please point me to what was updated?

[NickLarsenNZ]

@leoluz, IMO force-pushes (eg: after a rebase) are a good thing, to keep the commit history clean.

Github shows the changes since what you last see (see the Compare buttons below):

[leoluz]

@leoluz, IMO force-pushes (eg: after a rebase) are a good thing, to keep the commit history clean.

Github shows the changes since what you last see (see the Compare buttons below):

@NickLarsenNZ If you click the compare button you get the message:

There isn’t anything to compare.

Also, all my previous comments aren't visible in the diff page anymore. Just in the conversation timeline which is far from ideal.

Commit history in the PR branch doesn't matter that much. When we merge the PR into master is the right moment to squash and merge to have a clean timeline.

[NickLarsenNZ]

@leoluz

There isn’t anything to compare.

Yes I saw that on one of the changes. It just means it had been rebased (or commit messages changed) so commit IDs are now different, but no actual change since the last time you saw (so ignorable in that case).

Also, all my previous comments aren't visible in the diff page anymore. Just in the conversation timeline which is far from ideal.

From what I understand, comments in the diffs are bound to the commit IDs which are subject to change on non trunk (master) branches (like in this case). I think a better place to put comments are in the Review which will then show up in the PR (even once outdated).

When we merge the PR into master is the right moment to squash and merge to have a clean timeline.

That might be true for this particular case, but many times the contributor wants to pull in changes from the trunk (master) so it should probably be tolerated, if not expected.

---

I hope this covers your concerns. I think we should be making contribution easy, and I know many of us are looking forward to the image updater being merged into the main argo-cd repo.

[katainaka0503]

@jaideepr97 Any updates?

[jaideepr97]

@katainaka0503 based on further discussions with the contributor community it was decided that we need to further understand the long term motivation and plan for making image-updater a first class citizen within Argo CD. That would involve changes to the Application CRD to accomodate image update configuration among other things so I'm working on a different proposal for that at the moment, as that would make a more compelling case for having image updater merged into the core project

[jaideepr97]

Hi all, sorry for the delay on this
Just wanted to update here, you can find the follow up proposal here

All comments/feedback appreciated, TIA!

[Jojoooo1]

Awesome work! Any targeted release ?

[Guy-Rom]

Hi, is there ETA?
Any chance to add it as 2.10 target?

[brjadams]

What is happening with this?

[todaywasawesome]

For this proposal to move forward I think it needs a lot more support. The main issue with Image Updater right now is that it doesn't have enough maintainers working on it. We're working on cutting a new release as there hasn't been one in over a year.

If there are more people that support this, now is the time to chip in and help, and show your support.