Skip to content

docs: updated Azure AD instructions for user management#10216

Closed
schakko wants to merge 2 commits intoargoproj:masterfrom
dreitier:docs/update-instructions-for-microsoft-azure-ad
Closed

docs: updated Azure AD instructions for user management#10216
schakko wants to merge 2 commits intoargoproj:masterfrom
dreitier:docs/update-instructions-for-microsoft-azure-ad

Conversation

@schakko
Copy link

@schakko schakko commented Aug 5, 2022

The current documentation for setting up the Azure AD user management integration contains duplicate content and misses some instructions.
Content of this PR:

  • moved RBAC to its own section to prevent duplicate content
  • added scenario for mapping security groups to RBAC roles
  • added scenario for mapping application roles to RBAC roles
  • fixed indention of scope YAML key

Signed-off-by: Christopher Klein ckl@dreitier.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • (c) Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.64%. Comparing base (b0dab38) to head (865d0a8).
Report is 2391 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10216   +/-   ##
=======================================
  Coverage   45.64%   45.64%           
=======================================
  Files         239      239           
  Lines       28991    28991           
=======================================
  Hits        13233    13233           
  Misses      13939    13939           
  Partials     1819     1819           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @schakko! One top-level commend, then I'll come back for a more thorough review. :-)

@schakko schakko force-pushed the docs/update-instructions-for-microsoft-azure-ad branch from f010821 to 829cf1c Compare August 5, 2022 15:41
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more nitpicks. Otherwise LGTM. :-)

@schakko schakko force-pushed the docs/update-instructions-for-microsoft-azure-ad branch 2 times, most recently from e995f2e to f16f45b Compare August 10, 2022 13:37
* moved RBAC to its own section to prevent duplicate content
* added scenario for mapping security groups to RBAC roles
* added scenario for mapping application roles to RBAC roles
* fixed indention of `scope` YAML key
* fixed product naming ("Argo CD" w/ whitespaces)

Signed-off-by: Christopher Klein <ckl@dreitier.com>
@schakko schakko force-pushed the docs/update-instructions-for-microsoft-azure-ad branch from f16f45b to 8e8a0b1 Compare August 10, 2022 13:42
…re-ad

Signed-off-by: Schakko <schakkonator@googlemail.com>
@blakepettersson
Copy link
Member

This is pretty old, and there have been updates to the Azure AD (or Entra ID?) since. If there is anything that's still relevant to add, could you open a new PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants